Comment 1 Nicolas Bros 2010-05-06 08:51:45 EDT

Done in revision 2204, both for the query and facet editors.

Comment 2 Nicolas Bros 2010-05-07 04:36:23 EDT

Created attachment 167443 [details]
patch

Comment 3 Nicolas Guyomar 2010-05-07 11:09:44 EDT

Hi Nicolas,

Thanks for the enhancement.

When a modification is made from the properties panel on a facet/query, the editor is not automatically refresh. It is necessary to click in the editor (or close/open the querySet/facetSet) to see the red cross

Regards,

Nicolas

Comment 4 Nicolas Guyomar 2010-05-07 11:46:33 EDT

Hi again,

Broken references between a querySet and a facetSet raise an error in the problem tab and a red cross in the package explorer, but the red cross is not displayed in the editor

Procedure to reproduce : 

Create a querySet with a query
Create a facetSet with a facet referencing the previous query as condition query
Delete the query
Refersh/reopen the facetSet, no red cross on the concerned facet

Regards

Nicolas

Comment 5 Nicolas Bros 2010-05-07 11:50:53 EDT

Created attachment 167499 [details]
patch to fix the refresh problem

Comment 6 Nicolas Bros 2010-05-10 04:08:35 EDT

Created attachment 167663 [details]
patch to add error decorators for broken references

This patch adds error decorators for broken references, and selects the concerned element when double-clicking in the Problems view.

Comment 7 Hugo Bruneliere 2010-05-10 07:32:12 EDT

Nicolas,

You can go ahead with the patch.

Regards,

Hugo

Comment 8 Nicolas Bros 2010-05-10 08:41:32 EDT

Thanks. I applied the patches to branch 0_8_0 for RC1.

Comment 9 Nicolas Guyomar 2010-05-11 12:16:17 EDT

Hi Nicolas, Hugo,

Would it be possible to display the red cross on the parent when the error is detected on a facet's attribute/reference/shortcut ?

Regards

Nicolas

Comment 10 Nicolas Bros 2010-05-12 04:30:35 EDT

Created attachment 168096 [details]
patch to also show error markers on parents of items with errors

This patch adds error markers on parents of items with errors.

Comment 11 Nicolas Bros 2010-05-12 09:04:12 EDT

Fixed in revision 2260 (on trunk).

Comment 12 Nicolas Guyomar 2010-05-19 09:32:40 EDT

Hi again,

In order to be completely JDT like, could you also add the red cross on the tabbed panel title ?

Regards,

Nicolas

Comment 13 Nicolas Bros 2010-05-20 13:35:13 EDT

I added error decorators on the editor's tab in revision 2340.

In the future, could you make a separate bug for each separate request, please?
It would make it easier to track which changes are linked to which requirements.

Comment 14 Hugo Bruneliere 2010-10-01 13:37:25 EDT

Patch successfully committed.