Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 311584 - [build path] "Extend" path variable button does nothing
Summary: [build path] "Extend" path variable button does nothing
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 3.6 RC1   Edit
Assignee: Serge Beauchamp CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-04 12:22 EDT by Ryan Fong CLA
Modified: 2010-06-01 13:37 EDT (History)
1 user (show)

See Also:
daniel_megert: review+

Attachments
Fix (3.05 KB, patch)
2010-05-07 10:26 EDT, Serge Beauchamp CLA 		daniel_megert: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Fong CLA 2010-05-04 12:22:49 EDT 
Build Identifier: I20100429-1549

The "extend..." button in the Java project's link source dialog does not work.

Reproducible: Always

Steps to Reproduce:
* In the Java perspective, right click a Java project, goto Build Path > Link Source...
* Select Variables...
* In the dialog that appears, select an existing path variable and click Extend...

Effect:  Nothing happens.
Expected:  A file browser relative to the path variable appears.
Comment 1 Dani Megert CLA 2010-05-07 06:04:27 EDT 
Can reproduce using N20100505-2000. Works in 3.5.2. Broken since 3.6 M6.
Comment 2 Dani Megert CLA 2010-05-07 06:11:50 EDT 
This is a regression which must get fixed for 3.6.

Serge, your changes in 'org.eclipse.ui.ide.dialogs.PathVariableSelectionDialog' cause this. Can you please take a look.
Comment 3 Serge Beauchamp CLA 2010-05-07 10:26:57 EDT 
Created attachment 167479 [details]
Fix

Here's the fix, could you please review it Dani?  Thanks
Comment 4 Dani Megert CLA 2010-05-07 11:09:46 EDT 
Looks good. +1 for RC1.
Comment 5 Serge Beauchamp CLA 2010-05-10 05:48:17 EDT 
Thanks, now fixed on head.
Comment 6 Ryan Fong CLA 2010-06-01 13:37:41 EDT 
Great, fixed on RC2 (build ID: 20100527-0614).