Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 311558 - [ui] labels for guard predicates are not beautified
Summary: [ui] labels for guard predicates are not beautified
Status: VERIFIED FIXED
Alias: None
Product: Objectteams
Classification: Tools
Component: OTDT (show other bugs)
Version: 1.4   Edit
Hardware: Other All
: P3 normal (vote)
Target Milestone: 0.7 M2   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-04 10:19 EDT by Stephan Herrmann CLA
Modified: 2010-06-02 18:15 EDT (History)
0 users

See Also:

Attachments
fix (6.76 KB, patch)
2010-05-04 10:41 EDT, Stephan Herrmann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2010-05-04 10:19:15 EDT 
As of http://trac.objectteams.org/ot/ticket/179 the OTDT was able
to beautify the labels for guard predicates (no internal name, styling).
This was released for 1.2.5 but soon after broke again. I just checked 
1.3.2, where it is indeed broken.

A hint to the cause is found in http://trac.objectteams.org/ot/changeset/19982

The introducation of JavaElementLabelComposer was never fully adopted by
our ViewAdaptor.
Comment 1 Stephan Herrmann CLA 2010-05-04 10:41:34 EDT 
Created attachment 166961 [details]
fix

Fixed by moving trigger for callin beautifyGuardLabel: no longer intercept
method from JavaElementLabels but add a new role JavaElementLabelComposer,
adapting the same-named base class, which was introduced in 3.5.
This base class provides the real implementation for JavaElementLabels,
so adapting here provides for more consistency.
Comment 2 Stephan Herrmann CLA 2010-05-04 10:51:53 EDT 
Patch has been committed as r294.
Comment 3 Stephan Herrmann CLA 2010-06-02 18:15:39 EDT 
Post-hoc verified using M3.