Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 311556 - Java EE 6 facets should require at least Java 6
Summary: Java EE 6 facets should require at least Java 6
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P1 major (vote)
Target Milestone: 3.2 RC2   Edit
Assignee: Kaloyan Raev CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on: 252613
Blocks: 313368
  Show dependency tree
 
Reported: 2010-05-04 10:15 EDT by Carl Anderson CLA
Modified: 2010-05-19 23:56 EDT (History)
1 user (show)

See Also:
david_williams: pmc_approved+
kaloyan: pmc_approved? (raghunathan.srinivasan)
kaloyan: pmc_approved? (naci.dai)
kaloyan: pmc_approved? (deboer)
kaloyan: pmc_approved? (neil.hauge)
cbridgha: review+

Attachments
patch (2.60 KB, patch)
2010-05-14 06:42 EDT, Kaloyan Raev CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carl Anderson CLA 2010-05-04 10:15:41 EDT 
In bug 252613, we added in the various Java EE 6 facets.  All of them currently have the following line in their Java EE 6 version definition:

<requires facet="jst.java" version="[5.0"/>

The Java EE version should match the Java version.  (Java Enterprise Edition 6 is Java 6 Standard Edition plus Enterprise Edition support.)
Comment 1 Kaloyan Raev CLA 2010-05-14 06:42:37 EDT 
Created attachment 168523 [details]
patch

Simple patch that does the changes suggested by Carl.
Comment 2 Kaloyan Raev CLA 2010-05-14 06:43:04 EDT 
Chuck, please approve this simple fix for RC2.
Comment 3 Chuck Bridgham CLA 2010-05-17 11:29:54 EDT 
approve
Comment 4 Kaloyan Raev CLA 2010-05-18 02:37:28 EDT 
    * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

This is not a stop-ship defect, but users can easily end up with Java EE 6 projects created with Java 5 facets. Since Java EE 6 require Java 6 (because some of the Java EE libraries moved down to Java SE), then this can result in missing Java EE libraries in the project's classpath. 

    * Is there a work-around? If so, why do you believe the work-around is insufficient? 

The workaround is that users change the Java facet version from 5 to 6 during the project creation. But this is not an obvious thing for the general user. 

    * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

Manually tested. The validation of the facet framework shows error if the constraint is not satisfied. 

    * Give a brief technical overview. Who has reviewed this fix? 

Changed is the minimum required version of the jst.java facet from 5.0 to 6.0 for the Java EE 6 facets. This is a change done completely in the plugin.xml descriptors. 

    * What is the risk associated with this fix? 

No risk.
Comment 5 Kaloyan Raev CLA 2010-05-18 07:00:14 EDT 
Committed and released.
Comment 6 Kaloyan Raev CLA 2010-05-18 07:00:29 EDT 
Closing