Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 311474 - [debug view] Provide a default command handler for the Restart command.
Summary: [debug view] Provide a default command handler for the Restart command.
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.6 RC1   Edit
Assignee: Pawel Piech CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 289526
  Show dependency tree
 
Reported: 2010-05-04 00:17 EDT by Pawel Piech CLA
Modified: 2010-05-04 15:13 EDT (History)
2 users (show)

See Also:
darin.eclipse: review+


Attachments
Patch that adds the restart command handler. (3.12 KB, patch)
2010-05-04 00:17 EDT, Pawel Piech CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Piech CLA 2010-05-04 00:17:25 EDT
Created attachment 166901 [details]
Patch that adds the restart command handler.

The Restart action was added to the Debug view context menu with bug 286256.  It is visible only when the selected context adopts to IRestartHandler and it allows the selected process to be restarted without relaunching.  

The Restart action is available in the context menu and not in the top-menu so it is not accessible using keyboard only.  We only need to add a default command handler to enable the restart key binding to be used to activate the Restart command.
Comment 1 Pawel Piech CLA 2010-05-04 00:19:38 EDT
I would like to target this for RC1.  Darin please approve?
Comment 2 Darin Wright CLA 2010-05-04 12:29:55 EDT
+1 for RC1. However, should the handler extension be contributed as a "defaultHandler" on the command extension itself (rather than separately contriubuted to the handlers extension point).

@see TerminateAndRelaunchHandler as an example.
Comment 3 Pawel Piech CLA 2010-05-04 13:09:44 EDT
(In reply to comment #2)
> +1 for RC1.
Thank you, Committed.

> However, should the handler extension be contributed as a
> "defaultHandler" on the command extension itself (rather than separately
> contriubuted to the handlers extension point).
> 
> @see TerminateAndRelaunchHandler as an example.
Good point.  Functionally it makes no difference, but the use of defaultHandler makes the XML a little cleaner.
Comment 4 Darin Wright CLA 2010-05-04 15:13:15 EDT
Verified.