Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 311410 - TVT36:TCT108: CHS: Button Truncated
Summary: TVT36:TCT108: CHS: Button Truncated
Status: CLOSED FIXED
Alias: None
Product: Data Tools
Classification: Tools
Component: SQLDevTools (show other bugs)
Version: 1.8   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 1.8   Edit
Assignee: Brian Payton CLA
QA Contact:
URL: 108
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-03 14:34 EDT by CDE Administration CLA
Modified: 2010-05-31 07:36 EDT (History)
3 users (show)

See Also:


Attachments
108_08.000.500_truncation.gif (15.86 KB, image/gif)
2010-05-03 14:34 EDT, CDE Administration CLA
no flags Details
TCT#108_08.000.500_truncation.gif (22.58 KB, image/gif)
2010-05-03 14:34 EDT, CDE Administration CLA
no flags Details
08.000.500.gif (27.59 KB, image/gif)
2010-05-03 14:34 EDT, CDE Administration CLA
no flags Details
TCT108_TruncatedBox.gif (322.94 KB, image/gif)
2010-05-03 14:34 EDT, CDE Administration CLA
no flags Details
TCT108_TruncatedBox.gif (322.94 KB, image/gif)
2010-05-03 14:34 EDT, CDE Administration CLA
no flags Details
08.000.500.png (60.30 KB, image/png)
2010-05-03 14:34 EDT, CDE Administration CLA
no flags Details
Image showing SQL Results View preference page with long text values but no truncation (68.30 KB, image/gif)
2010-05-10 20:53 EDT, Brian Payton CLA
no flags Details
SQLResultsViewerOptionsTrunction.gif (68.30 KB, image/gif)
2010-05-10 21:06 EDT, CDE Administration CLA
no flags Details
new ResultSetViewerPreferencePage.java (12.21 KB, text/plain)
2010-05-12 02:45 EDT, Kit Lo CLA
no flags Details
screen capture (31.51 KB, image/x-png)
2010-05-12 02:47 EDT, Kit Lo CLA
no flags Details
Patch for o.e.d.sqltools.result.ui (3.76 KB, patch)
2010-05-12 15:41 EDT, Brian Payton CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description CDE Administration CLA 2010-05-03 14:34:29 EDT
<response_by> Ma Xiao Long at 2010.05.02.23.46.05 </response_by>
NLS Build Label: 20100426-1300-nl1
Language: S.Chinese

- Steps To Recreate Problem:
1)  Start Eclipse and change the Perspective to Database Development Perspective from Window->Open Perspective->Other?
2)  When the Database Development Perspective opens, verify the Data Source Explorer (DSE) opens.  It should contain the Databases folder
3)  Open the Project Explorer View by selecting Window -> Show View -> Other... expand the General folder and select Project Explorer
4)  Create a project named test by selecting File -> New -> Project... expand the General folder and select Project.
5)  Open the Preference pages for SQL Development by selecting Window -> Preferences, expand Data Management -> SQL Development
6)  Expand SQL Results View Options and select Viewer Options
7)  Verify the text in the window below
8 ) Click Cancel to exit from Preferences dialog

- Problem Description:
We found truncation, pls help to check, thanks!

<response_by> Lisa Chang at 2010.05.03.04.10.38 </response_by>
Same problem for CHT

<response_by> maria cristina caroletti at 2010.05.03.07.19.12 </response_by>
Same problem for ITA.
Kind Regards
Alessandro

<response_by> Albatros at 2010.05.03.07.29.06 </response_by>
Same problem for Turkish.
Thanks,
Nilgun.

<response_by> Anna Routsi at 2010.05.03.10.19.25 </response_by>
Hello,

Same problem for Greek.

Thanks,
Anna

<response_by> martine marin at 2010.05.03.10.26.29 </response_by>
Same for France.
Martine

<response_by> martine marin at 2010.05.03.10.26.39 </response_by>
Same for France.
Martine

<response_by> rewagner at 2010.05.03.10.35.59 </response_by>
This article was reassigned from Category:''TVT/Testing,Product/Functional Issues''.

<response_by> Manuel Ferro at 2010.05.03.11.14.27 </response_by>
Same problem for PTG.

Regards,
Ricardo

<response_by> Emilio Cifuentes at 2010.05.03.11.28.41 </response_by>
Same problem for spanish.

Thanks
Emilio
Comment 1 CDE Administration CLA 2010-05-03 14:34:37 EDT
Created attachment 166832 [details]
108_08.000.500_truncation.gif
Comment 2 CDE Administration CLA 2010-05-03 14:34:40 EDT
Created attachment 166833 [details]
TCT#108_08.000.500_truncation.gif
Comment 3 CDE Administration CLA 2010-05-03 14:34:42 EDT
Created attachment 166834 [details]
08.000.500.gif
Comment 4 CDE Administration CLA 2010-05-03 14:34:47 EDT
Created attachment 166835 [details]
TCT108_TruncatedBox.gif
Comment 5 CDE Administration CLA 2010-05-03 14:34:50 EDT
Created attachment 166836 [details]
TCT108_TruncatedBox.gif
Comment 6 CDE Administration CLA 2010-05-03 14:34:53 EDT
Created attachment 166837 [details]
08.000.500.png
Comment 7 CDE Administration CLA 2010-05-03 14:35:20 EDT
<cde:tctdetail>
Testcase: 08.000.500 - DTP - RESULT SET VIEWER OPTIONS PAGE
Project: WSW36
Component: Xfer - Data Tools/Data Source Explorer
Priority: 2
Subject: CHS: Button Truncated
Article ID: 108
Originator: maxl@szchkj.com.cn
</cde:tctdetail>
Comment 8 CDE Administration CLA 2010-05-03 17:47:02 EDT
<response_by> rewagner at 2010.05.03.16.41.05 </response_by>
Changing status to working
Comment 9 CDE Administration CLA 2010-05-04 03:56:23 EDT
<response_by> Katia Milekhina at 2010.05.04.02.36.06 </response_by>
Same problem for Russia.

Regards,
Katia
Comment 10 CDE Administration CLA 2010-05-04 14:18:34 EDT
<response_by> Kathy Li at 2010.05.04.13.06.17 </response_by>
Must-Fix: Yes
Comment 11 Brian Payton CLA 2010-05-10 20:52:09 EDT
I can't reproduce this problem.  I used the Babel Pseudo Translation to get long text values (that I could still read) but I didn't see any truncation for the fields reported in this defect.  

Next I hacked the pseudo translation to make the text values even longer, and the fields still expand properly to show the entire string.

I am attaching an image showing the fields properly expanded with the extra long text values.
Comment 12 Brian Payton CLA 2010-05-10 20:53:18 EDT
Created attachment 167851 [details]
Image showing SQL Results View preference page with long text values but no truncation
Comment 13 CDE Administration CLA 2010-05-10 21:06:12 EDT
Created attachment 167854 [details]
SQLResultsViewerOptionsTrunction.gif
Comment 14 Brian Payton CLA 2010-05-10 21:09:19 EDT
The layout control for these controls does not specify a width, and the combo
control is free to grab excess space.  Here's the code that creates the result
set viewer label and combo box:

        GridData gridData = new GridData(GridData.FILL_HORIZONTAL);
        gridData.horizontalSpan=2;
        resultViewersGroup.setLayoutData(gridData); 
        GridLayout gLayout = new GridLayout();
        gLayout.numColumns = 2;
        resultViewersGroup.setLayout(gLayout);
        Label label = new Label(resultViewersGroup, SWT.NONE);
        label.setText(Messages.ResultSetViewerPage_select_viewer);
        viewersCombo = new Combo(resultViewersGroup, SWT.DROP_DOWN |
SWT.READ_ONLY);
       
viewersCombo.setToolTipText(Messages.ResultSetViewerPage_viewer_tooltip);
        GridData comboData = new GridData();
        comboData.grabExcessHorizontalSpace = true;
        viewersCombo.setLayoutData(comboData);

If a SWT/JFace expert can point whether this code is doing something wrong, I'd
appreciate it.
Comment 15 Brian Payton CLA 2010-05-10 21:10:58 EDT
Please reopen if you can help me understand why the layout truncates for one language but not another with much longer text value length.
Comment 16 CDE Administration CLA 2010-05-10 21:21:23 EDT
Attachment added by CDE
Comment 17 CDE Administration CLA 2010-05-11 12:38:19 EDT
Attachment added by CDE

<response_by> Kathy Li at 2010.05.11.11.24.16 </response_by>
I have tried to use I20100429-1549(NL Build version : 20100509-1500-nl1). I still see truncation in CHS. Please continue to investigate as this is listed as must-fix and it happens to quite a few countries.

If needed, you are welcome to use one of TVT English server with MUI for this test. Please ping me for machine information.

thanks

Kathy
Comment 18 Kit Lo CLA 2010-05-12 02:45:01 EDT
Created attachment 168086 [details]
new ResultSetViewerPreferencePage.java

Brian, I don't have connection to the DTP repository. I didn't create a patch. But, this seems to resolve the truncation problem. Please review.
Comment 19 Kit Lo CLA 2010-05-12 02:47:25 EDT
Created attachment 168087 [details]
screen capture

Here are the pictures (in French) before and after the fix.
Comment 20 CDE Administration CLA 2010-05-12 02:57:08 EDT
Attachment added by CDE
Comment 21 Brian Payton CLA 2010-05-12 15:41:07 EDT
Reopening, since we have a new proposed fix.
Comment 22 Brian Payton CLA 2010-05-12 15:41:45 EDT
Created attachment 168243 [details]
Patch for o.e.d.sqltools.result.ui
Comment 23 Brian Payton CLA 2010-05-12 15:43:13 EDT
I tested Kit's code, and it looks like it works fine.  I have created and attached a patch.
Comment 24 Brian Payton CLA 2010-05-12 15:49:59 EDT
Checked in fix, tagged to v201005130345.

Thanks Kit!
Comment 25 CDE Administration CLA 2010-05-12 16:20:47 EDT
Attachment added by CDE
Comment 26 CDE Administration CLA 2010-05-14 15:42:59 EDT
Attachment added by CDE

Attachment added by CDE

Attachment added by CDE

Attachment added by CDE

Attachment added by CDE
Comment 27 CDE Administration CLA 2010-05-20 03:07:43 EDT
<response_by> Ma Xiao Long at 2010.05.20.01.55.45 </response_by>
Fixed fo CHS in build 20100518-2000-nl1, thanks!
Comment 28 CDE Administration CLA 2010-05-20 03:22:25 EDT
Attachment added by CDE
Comment 29 CDE Administration CLA 2010-05-20 03:27:18 EDT
Attachment added by CDE
Comment 30 CDE Administration CLA 2010-05-20 05:17:20 EDT
<response_by> martine marin at 2010.05.20.03.57.40 </response_by>
Fixed for France
Verified in buid 20100519-1300
Thanks a lot,
Martine
Comment 31 CDE Administration CLA 2010-05-20 05:22:03 EDT
Attachment added by CDE
Comment 32 CDE Administration CLA 2010-05-21 11:22:55 EDT
Attachment added by CDE

<response_by> Manuel Ferro at 2010.05.21.10.16.11 </response_by>
It's fine, for portuguese, in build 20100520-0200

Regards,
Ricardo
Comment 33 CDE Administration CLA 2010-05-27 00:22:35 EDT
Attachment added by CDE

<response_by> Lisa Chang at 2010.05.26.23.09.11 </response_by>
fixed in build 20100518-2000-nl1 for CHT
Comment 34 CDE Administration CLA 2010-05-27 00:36:52 EDT
Attachment added by CDE
Comment 35 CDE Administration CLA 2010-05-31 06:07:47 EDT
Attachment added by CDE

<response_by> maria cristina caroletti at 2010.05.31.05.00.10 </response_by>
Hi
It's fixed, for italian, in build 20100529-2200
Regards,
Alessandro
Comment 36 CDE Administration CLA 2010-05-31 07:22:39 EDT
Attachment added by CDE

<response_by> Emilio Cifuentes at 2010.05.31.06.19.45 </response_by>
Hi

Fixed for spanish.

Thanks
Emilio
Comment 37 CDE Administration CLA 2010-05-31 07:36:53 EDT
Attachment added by CDE