Description Larry Isaacs 2010-05-03 09:49:40 EDT

Created attachment 166774 [details]
Patch to add check for binary references to AddComponentToEnterpriseApplicationDataModelProvider

If you add a binary jar reference (or other type of binary reference for that matter) to an EAR project using the Deployment Assembly page, it will initially appear correct.  However, if you close and re-open the Deployment Assembly page, that reference will include an extra ".jar" on the end of the Deploy Path.

The culprit appears to be AddComponentToEnterpriseApplicationDataModelProvider, where the default map it creates for TARGET_COMPONENTS_TO_URI_MAP is incorrect.  It appears to only be expecting project type references since it is using the project to test for the type of reference, which will be the parent EAR project for binary references.  This causes method to always add ".jar" by default.  As far as I know, binary references will already include the file's extension in the name, so adding another extension is unnecessary.  The attached patch adds an isBinary() check to avoid the extra extension.

Marking major since if a binary war file was referenced, changing the extension to ".jar" could affect deployment.