Community
Participate
Working Groups
Build Identifier: There are currently no UI for tagging EGit. We can only browse already created tags in branch dialog. There should be an additional dialog that will allow us to create and edit tag. This dialog should contains: * input for tag name * text area for tag message * an advanced section that will allow select commit that should be associated with this tag * list of already created tags with possibility of making changes in tag message and associated commit Additionally there should be also an validation mechanism that will disallow creating bad named tags. Reproducible: Always
I've send implementation for this feature to Gerrit: http://egit.eclipse.org/r/#change,544 It has implemented not only creating a new tag but also editing an existing tag (by 'editing' I mean changing tag message and associated commit).
I think the dialog to create and edit tags should be also reachable from the following views : - Mathias added a separate node for tags in the git repositories view with change http://egit.eclipse.org/r/#change,621. As soon as this passed review the "Tag..." action should also be added to its context menu. - In the history view it should be also added, this would be useful especially to create tags on old commits.
(In reply to comment #2) > - In the history view it should be also added, this would be useful especially > to create tags on old commits. I would open another enhancement request (bug) for this. It would be nice to do things in a piece meal fashion, this patch is getting big enough :)
(In reply to comment Matthias Sohn commient in Gerrit) > We'll need a CQ for IP review since this change is way larger than 250 > lines hence marking this as unclean IP. I'll create the CQ as soon as > this change has settled and review is fine. > > I played around with the UI, in general you are moving in the right direction :) > > I think from usability perspective we need some polishing: > - the label for the tag name should be just "Tag name*:" > more detailed descriptions should IMO go into the online help or a > tooltip (don't know what the Eclipse UI guidelines recommend here) This is also fine for me, I'll change label and tooltip to 'tag name' input field > - it would be useful to see the branch name the tag will be created on I'm not quite sure where we can put that information, but I fully agree with you that this kind of information would be very useful. Right now I think that we can add branch name to window title and maybe include it in some kind of general message above 'Tag name' label. Any other suggestions ? > - IMO the list of existing tags for the given branch should be always > shown as another list on the left side of the dialog (probably this > should be sorted in reverse chronological order, means latest on top). > I didn't expect to find this list behind the "Details >>" button. OK, I'll change implementation so that list of existing tags will be always shown on left side of dialog window. According to Pro Git book[2] tag names in git are always sorted alphabetically I'm not sure that we want to change this behavior in UI. > - when entering a tag name which already exists the tag list should > scroll to this already existing tag and the tag name edit field > background should turn red to make the user aware of the fact that > this tag already exists. Maybe then a help text should appear "Tag xyz > already exists, if you want to replace it check the force option". Instead of 'scrolling down' I'll rather prefer reduce number of displayed tags in tag list so that user can select one from this list if he want to replace it. > - if an existing branch has been selected from the list there is no > way to create a new tag anymore except closing and re-opening the > dialog. This could be solved by adding a pseudo entry in the list > which is named e.g. <create new tag>. Selecting this entry should then > clear all the edit fields so that a new tag can be defined. I'm not quite sure about this behavior. Default action of this dialog should be 'create tag' not 'edit tag'. This means that when user fires it he want to create tag and he want to do this as quick and simple as it can be. For this reason I've hide list of existing tags and commit selection. Maybe I have bad impression of user needs ... > - I think the label "Overwrite existing tag" should be changed to > "Force: replace existing tag" (see description of -f in [1], as long > as this checkbox is not checked the data for an existing tag should be > read-only. Then users will rather think twice before they change an > existing tag. +1 for renaming and 'read-only-mode' for existing tags. > - the advanced mode is cool :) I think the label should be a bit more > to the point, e.g. "Select commit to tag". To notify the user that he > can start typing display the little bulb icon in front of the edit > field (used e.g. for the URI field of clone wizard you open via > "Import > Git Repository") and display the explanation as a tooltip on > this icon. Nice idea! I'll add this bulb icon and tooltip ;) > [1] http://www.kernel.org/pub/software/scm/git/docs/git-tag.html [2] - http://progit.org/book/ch2-6.html
Created attachment 167607 [details] Screenshot depicting the problem in question. The dialog from patch set 6 has alignment problems. In the left hand side there's a margin but there isn't one on the right. Personally, I'm not too down with this whole border idea but maybe that's just me.
(In reply to comment #5) > Created an attachment (id=167607) [details] > Screenshot depicting the problem in question. > > The dialog from patch set 6 has alignment problems. In the left hand side > there's a margin but there isn't one on the right. Personally, I'm not too down > with this whole border idea but maybe that's just me. Fixes for that issue will be included in patch set 7.
attached patchset 10 to CQ 4073 for IP review
Dariusz could you please make the following explicit legal statements regarding your contribution coming with this bug : a. confirm you authored 100% of the content b. confirm you have the rights to contribute the content to Eclipse c. confirm you are contributing the content under the EPL Here the corresponding contribution rules: - "Appropriateness of Contributions" in [1] - Figure 11b in [2] [1] http://www.eclipse.org/legal/committerguidelines.php [2] http://www.eclipse.org/legal/EclipseLegalProcessPoster.pdf
(In reply to comment #8) > Dariusz could you please make the following explicit legal statements regarding > your contribution coming with this bug : > > a. confirm you authored 100% of the content Not exactly, in CreateTagDialog I've copy-pasted part of code from org.eclipse.jface.dialogs.InputDialog.setErrorMessage(String) but this is explicit commented in code (line 535). In case of rest of code I'm a 100% author of it > b. confirm you have the rights to contribute the content to Eclipse Yes, I have full rights to contribute this code to Eclipse > c. confirm you are contributing the content under the EPL Yes, code is contributed under EPL.
I think we can close this generic enhancement request?
Yes, done.
