Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 311249 - 'Show In > History' is broken
Summary: 'Show In > History' is broken
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 major (vote)
Target Milestone: 0.8.0   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-30 17:44 EDT by Remy Suen CLA
Modified: 2010-05-02 03:27 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-04-30 17:44:22 EDT
Please bring back 'Team > Show History' _and_ fix 'Show In'.

If you try to show the history for ConfigureUriPage, you'll just get a blank page. Attempting to show some other Java files will all end in failure. If you try a MANIFEST.MF file, it should work. But now you'll be stuck on that file.
Comment 1 Remy Suen CLA 2010-04-30 18:34:16 EDT
(In reply to comment #0)
> If you try to show the history for ConfigureUriPage, you'll just get a blank
> page. Attempting to show some other Java files will all end in failure. If you
> try a MANIFEST.MF file, it should work. But now you'll be stuck on that file.

A suggested change set has been attached to Gerrit.
http://egit.eclipse.org/r/634

As to bringing back 'Team > Show History', well, I like it because CVS has it in both places but up to ya'll I suppose.
Comment 2 Matthias Sohn CLA 2010-05-01 05:17:23 EDT
(In reply to comment #0)
> Please bring back 'Team > Show History' _and_ fix 'Show In'.
> If you try to show the history for ConfigureUriPage, you'll just get a blank
> page. Attempting to show some other Java files will all end in failure. If you
> try a MANIFEST.MF file, it should work. But now you'll be stuck on that file.

I can't reproduce this problem on Windows XP, please specify which repository contains ConfigureUriPage and which EGit/JGit version you are using. In which perspective are you trying to use Show In > History ? 

The first change  http://egit.eclipse.org/w/?p=egit.git;a=commit;h=4eba4bd50103d65bdb88755b4d0bea6581b4ea79  Mathias did only worked properly in the resource perspective. This was fixed with change http://egit.eclipse.org/w/?p=egit.git;a=commit;h=d47b006c5269bb9427baeec129ed3f8e9b0aaa57.
Comment 3 Remy Suen CLA 2010-05-01 06:18:31 EDT
(In reply to comment #2)
> I can't reproduce this problem on Windows XP, please specify which repository
> contains ConfigureUriPage and which EGit/JGit version you are using.

It's from EGit and was added on the 27th.
org.eclipse.egit.ui.internal.repository.ConfigureUriPage
cd5d7c723112558b5918d628486400aa9af8b014

Though it actually doesn't matter if you use this file or not. See below.

> In which perspective are you trying to use Show In > History ?

Try it using 'Package Explorer' or 'Project Explorer' in the 'Java' perspective with the latest nightlies. You will not be able to show the history of any .java files. You can also try from the Java editor. They will fail. Well, the view comes up, but it won't be populated. 'Navigator' is okay though.
Comment 4 Remy Suen CLA 2010-05-01 06:28:38 EDT
(In reply to comment #3)
> Try it using 'Package Explorer' or 'Project Explorer' in the 'Java' perspective
> with the latest nightlies.

Actually, based on the code, and my experiences from trying it before, the code has been broken for some time (if not broken since the beginning).

And to be clear, you need to be using the 'Show In' submenu. Or invoke Ctrl+Shift+W.
Comment 5 Chris Aniszczyk CLA 2010-05-02 03:27:13 EDT
Merged, thanks Remy.