Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 311219 - [commands][cdi] MITargetSelect is too restrictive
Summary: [commands][cdi] MITargetSelect is too restrictive
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf-gdb (show other bugs)
Version: 7.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 7.0   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact: Marc Khouzam CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-30 13:31 EDT by Nobody - feel free to take it CLA
Modified: 2010-07-28 15:25 EDT (History)
1 user (show)

See Also:
nobody: iplog-

Attachments
Makes the generic constructor public and modifies CommandFactory. (2.08 KB, patch)
2010-04-30 13:31 EDT, Nobody - feel free to take it CLA 		nobody: iplog-
Details | Diff
Updated patch. (2.08 KB, patch)
2010-05-02 18:32 EDT, Nobody - feel free to take it CLA 		nobody: iplog-
Details | Diff
Take two (or three) (2.15 KB, patch)
2010-05-03 09:58 EDT, Nobody - feel free to take it CLA 		nobody: iplog-
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nobody - feel free to take it CLA 2010-04-30 13:31:44 EDT 
Created attachment 166649 [details]
Makes the generic constructor public and modifies CommandFactory.

Currently MITargetSelect implementation is restricted to some specific cases. It is possible to subclass it, but the subclassing requires a new CommandFactory which requires a new IGDBControl implementation, etc.
The attached patch simply changes the protected constructor of MITargetSelect and adds a new factory method to CommandFactory. Again not sure what to do with the "since" tag. It is set to 2.0, should I cahnge it for 3.0?
Comment 1 Marc Khouzam CLA 2010-04-30 13:47:25 EDT 
Looks good to me.
The API tooling gave me an error if I didn't change the @since to 3.0
Comment 2 Nobody - feel free to take it CLA 2010-05-02 18:32:09 EDT 
Created attachment 166740 [details]
Updated patch.
Comment 3 Nobody - feel free to take it CLA 2010-05-02 18:33:17 EDT 
Updated @since tag.
Comment 4 Marc Khouzam CLA 2010-05-03 09:14:55 EDT 
(In reply to comment #2)
> Created an attachment (id=166740) [details]
> Updated patch.

Seems identical to the previous one :-)
Comment 5 Nobody - feel free to take it CLA 2010-05-03 09:58:11 EDT 
Created attachment 166776 [details]
Take two (or three)
Comment 6 Nobody - feel free to take it CLA 2010-05-03 09:59:33 EDT 
Almost did it again. Sorry Marc.
Comment 7 Marc Khouzam CLA 2010-05-03 10:05:51 EDT 
(In reply to comment #6)
> Almost did it again. Sorry Marc.

:-)

Looks great.
Comment 8 Nobody - feel free to take it CLA 2010-05-03 11:19:08 EDT 
Committed to the HEAD.