Comment 1 Marc Khouzam 2010-04-30 11:30:52 EDT

Thanks to the JUnit tests I realized this 'fix' was bad.

I wanted to optimize:

for ( CommandInfo unqueuedCommand : new ArrayList<CommandInfo>(fPendingQCommandsNotYetSent) ) {
   if ( unqueuedCommand.equals( cachedCmd )) {
        fPendingQCommandsNotYetSent.remove(unqueuedCommand);
        fPendingQCommandsSent.add(unqueuedCommand);
        break;
   }
}


the problem turns out to be that 'cachedCmd' although considered equals() with 'unqueuedCommand', is not actually identical.  'cachedCmd' does not contain the list of requestMonitors that unqueuedCommand contains.

So, we actually need to fetch unqueuedCommand from the fPendingQCommandsNotYetSent map before inserting it in fPendingQCommandsSent

I've added a comment in the method to explain this.