Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 311162 - Don't set caret to 'null'
Summary: Don't set caret to 'null'
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 RC1   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks: 293263
  Show dependency tree
 
Reported: 2010-04-30 08:20 EDT by Dani Megert CLA
Modified: 2010-05-17 09:32 EDT (History)
2 users (show)

See Also:
markus.kell.r: review+

Attachments
Fix (7.51 KB, patch)
2010-05-02 06:18 EDT, Dani Megert CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2010-04-30 08:20:30 EDT 
I20100429-1549.
Comment 1 Dani Megert CLA 2010-04-30 08:21:23 EDT 
See bug 293263 for details.
Comment 2 Dani Megert CLA 2010-04-30 08:39:19 EDT 
Will fix org.eclipse.ui.texteditor.templates.TemplatePreferencePage.doCreateViewer(Composite) along with this bug.
Comment 3 Dani Megert CLA 2010-05-02 06:18:57 EDT 
Created attachment 166730 [details]
Fix
Comment 4 Dani Megert CLA 2010-05-02 06:24:19 EDT 
Markus please +1 for RC1 and review the patch. Thanks.
Comment 5 Markus Keller CLA 2010-05-03 09:01:06 EDT 
+1 for RC1. I didn't find any remaining problematic calls to setCaret(..).

I would end the comments with "<https://bugs.eclipse.org/293263>." or "https://bugs.eclipse.org/293263 ." (to make Ctrl+click work).
Comment 6 Dani Megert CLA 2010-05-03 10:47:34 EDT 
(In reply to comment #5)
> +1 for RC1. I didn't find any remaining problematic calls to setCaret(..).
> 
> I would end the comments with "<https://bugs.eclipse.org/293263>." or
> "https://bugs.eclipse.org/293263 ." (to make Ctrl+click work).

Done.

Committed to HEAD.
Available in builds > N20100502-2000.
Comment 7 Raksha Vasisht CLA 2010-05-17 09:11:46 EDT 
Starting to verify...
Comment 8 Raksha Vasisht CLA 2010-05-17 09:32:34 EDT 
Verifed for 3.6RC1 with N20100516-2000.