Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 311148 - SearchPageDescriptor#computeScore(Object) should test alternatives
Summary: SearchPageDescriptor#computeScore(Object) should test alternatives
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Search (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.6 RC1   Edit
Assignee: Platform-Search-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-30 05:37 EDT by Markus Keller CLA
Modified: 2010-05-17 08:25 EDT (History)
2 users (show)

See Also:

Attachments
Fix testing both (2.24 KB, patch)
2010-04-30 05:37 EDT, Markus Keller CLA 		daniel_megert: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2010-04-30 05:37:00 EDT 
Created attachment 166598 [details]
Fix testing both

Follow-up to bug 292924 (and bug 299151 and bug 310687)

In 3.5, the score for file extensions always won. Now, an ISearchPageScoreComputer is always tested first, but even if it returns UNKNOWN, the whole computeScore(..) method returns UNKNOWN, without further testing whether there is a score for file extensions.

We should at least fall back to the file extension if the ISearchPageScoreComputer returned UNKNOWN.

I would even do both tests and return the higher of the scores. The patch implements this strategy.
Comment 1 Dani Megert CLA 2010-04-30 08:13:04 EDT 
Makes sense.
Comment 2 Dani Megert CLA 2010-05-01 03:33:43 EDT 
The extension point doc says:

Note: This only applies if there is no org.eclipse.search.ui.ISearchPageScoreComputer adapter for the selected element.

Hence we should not try both but fall back in case of unknown and mention this case in the extension point doc.

Markus, do you agree?
Comment 3 Markus Keller CLA 2010-05-01 10:54:05 EDT 
(In reply to comment #2)
That note has only been added during 3.6 (with bug 292924). Before, the ISearchPageScoreComputer was not even mentioned, and clients could assume that the "extensions" list was the only weight that was used.

I think trying both mechanism offers the maximum flexibility and does not cause more problems than always letting the ISearchPageScoreComputer win if it has a score.
Comment 4 Dani Megert CLA 2010-05-02 01:35:01 EDT 
Oh, yes, you are right. The note was added in 3.6. Then I agree. I take your patch plus adjust the extension point doc.

I guess it's now time for you to get commit rights here ;-)
Comment 5 Dani Megert CLA 2010-05-02 01:56:08 EDT 
Fixed in HEAD with attached patch plus updated doc.
Available in build > N20100501-2000.
Comment 6 Dani Megert CLA 2010-05-17 08:25:55 EDT 
Verified in N20100516-2000.