Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 311116 - [Outline] Regression: Outline nodes with EObject#toString() as label
Summary: [Outline] Regression: Outline nodes with EObject#toString() as label
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 1.0.0   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: RC1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-29 17:11 EDT by Sebastian Zarnekow CLA
Modified: 2017-09-19 15:58 EDT (History)
1 user (show)

See Also:
sebastian.zarnekow: helios+

Attachments
proposed patch (7.16 KB, patch)
2010-05-06 15:58 EDT, Michael Clay CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Zarnekow CLA 2010-04-29 17:11:31 EDT 
The default implementation of the EObjectLabelProvider will delegate to an AdapterFactoryLabelProvider if the EObject has no customized text(..) method and no name-Feature. The AdapterFactoryLabelProvider in turn will invoke toString() on the object, if no specific provider is available. This renders the default outline basically unusable for non trivial languages, e.g. even the outline of the Domainmodel contains nodes for TypeRefs labeled "org.eclipse.xtext.example....TypeRefImpl@012345".
Comment 1 Sebastian Zarnekow CLA 2010-04-29 17:13:06 EDT 
Proposed solution: Find a way to identify unreadable default labels and let consumeNode(..) return false for these objects.
Comment 2 Michael Clay CLA 2010-05-06 15:58:31 EDT 
Created attachment 167381 [details]
proposed patch
Comment 3 Michael Clay CLA 2010-05-06 15:59:10 EDT 
fixed in HEAD. pls verify
Comment 4 Karsten Thoms CLA 2017-09-19 15:58:12 EDT 
Closing bug which were set to RESOLVED before Eclipse Neon.0.