Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 311102 - [LRParser] LR parser test failures caused by miscast
Summary: [LRParser] LR parser test failures caused by miscast
Status: RESOLVED WORKSFORME
Alias: None
Product: CDT
Classification: Tools
Component: cdt-core (show other bugs)
Version: 7.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Doug Schaefer CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-29 15:51 EDT by Charley Wang CLA
Modified: 2011-01-22 06:41 EST (History)
1 user (show)

See Also:

Attachments
patch for LR Tests (4.62 KB, text/plain)
2010-04-29 15:52 EDT, Charley Wang CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Charley Wang CLA 2010-04-29 15:51:30 EDT 
The proposed patch fixes some errors in the LR Parser tests that have been showing up in the Hudson build.

Tests:
org.eclipse.cdt.core.lrparser.tests.LRTests.testDesignatedInitializers 
org.eclipse.cdt.core.lrparser.tests.LRTests.testMoregetDeclarationsInAST1 
org.eclipse.cdt.core.lrparser.tests.LRTests.testMoregetDeclarationsInAST2 
org.eclipse.cdt.core.lrparser.tests.LRTests.testMoregetDeclarationsInAST3 

were failing with miscasts (from CASTInitializerList -> IASTEqualsInitializer)

Patch is applied to AST2Tests, which LRTests extends. It also should not  adversely affect the AST2Tests. 

The patch just adds a function to do some quick type checking and handles an object appropriately.

-Charley
Comment 1 Charley Wang CLA 2010-04-29 15:52:14 EDT 
Created attachment 166562 [details]
patch for LR Tests

Attached patch.
Comment 2 James Blackburn CLA 2011-01-22 06:41:00 EST 
These tests are no longer failing, though there are a bunch of lrparser failures:
https://hudson.eclipse.org/hudson/job/cdt-nightly/lastCompletedBuild/testReport/