Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 311097 - [NLS] validation builder job uses incorrect message
Summary: [NLS] validation builder job uses incorrect message
Status: CLOSED FIXED
Alias: None
Product: WTP Common Tools
Classification: WebTools
Component: wst.validation (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 RC1   Edit
Assignee: Wini Mark CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-29 15:10 EDT by Karen Butzke CLA
Modified: 2010-06-16 13:20 EDT (History)
4 users (show)

See Also:
david_williams: pmc_approved+
ccc: pmc_approved? (raghunathan.srinivasan)
ccc: pmc_approved? (naci.dai)
ccc: pmc_approved? (deboer)
ccc: pmc_approved? (neil.hauge)
ccc: pmc_approved? (kaloyan)
karasiuk: review+
ccc: review+

Attachments
Fix the message (3.86 KB, patch)
2010-04-29 16:37 EDT, Wini Mark CLA 		valentinbaciu: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karen Butzke CLA 2010-04-29 15:10:44 EDT 
When the Validation builder job runs the progress monitor displays:
Validation [project_name]
instead of:
Validating [project_name]
Comment 1 Valentin Baciu CLA 2010-04-29 15:23:34 EDT 
Hi Karen, is this the same behaviour described in bug 308541?

*** This bug has been marked as a duplicate of bug 308541 ***
Comment 2 Karen Butzke CLA 2010-04-29 15:27:29 EDT 
Nope, this is a different message, I am using today's Ibuild in testing this.  The code I am looking at is line 164 of ValBuildJob:

setName(ValMessages.JobName + " " + request.getProject().getName()); //$NON-NLS-1$

ValMessages.JobName is Validation, which is fine for the Job name.
Comment 3 Valentin Baciu CLA 2010-04-29 15:43:18 EDT 
Thanks Karen, let's see if we can get this fix in for M7.

Wini, I think it would be even better to have message with parameter instead of using string concatenation there.
Comment 4 Wini Mark CLA 2010-04-29 16:37:42 EDT 
Created attachment 166569 [details]
Fix the message
Comment 5 Wini Mark CLA 2010-04-29 17:07:12 EDT 
Talked to Carl and it's too late for M7. We will fix it in RC1.
Comment 6 Carl Anderson CLA 2010-05-03 10:33:19 EDT 
Requesting PMC approval for WTP 3.2 RC1 for this additional string.
There's no workaround here - we are just using a new string to correctly aggregate the message content as well as properly fix the grammar used.
This has been tested by hand.  Since it is a simple string fix, there is no JUnit test.  Gary Karasiuk and myself have reviewed the fix.  This is an extremely low risk fix.
Comment 7 David Williams CLA 2010-05-03 11:17:22 EDT 
I think this is worth it (frequently seen, low risk).
Comment 8 Valentin Baciu CLA 2010-05-06 15:00:08 EDT 
Carl, please commit and release (Wini is not a committer).
Comment 9 Carl Anderson CLA 2010-05-06 21:36:03 EDT 
Committed to HEAD for WTP 3.2 RC1
Comment 10 Karen Butzke CLA 2010-05-13 10:33:32 EDT 
verified fixed in build WTP-I-3.2.0-20100513045407
Comment 11 Valentin Baciu CLA 2010-06-16 13:20:56 EDT 
Closing.