Community
Participate
Working Groups
In 3.x, we have an ActionHandler. In e4, we're in an WidgetMethodHandler. Thread [main] (Suspended) CopyToClipboardAction.run(IStructuredSelection) line: 112 CopyToClipboardAction(SelectionDispatchAction).dispatchRun(ISelection) line: 274 CopyToClipboardAction(SelectionDispatchAction).run() line: 250 CopyToClipboardAction(Action).runWithEvent(Event) line: 498 ActionHandler.execute(ExecutionEvent) line: 119 Command.executeWithChecks(ExecutionEvent) line: 476 ParameterizedCommand.executeWithChecks(Object, Object) line: 508 HandlerService.executeCommand(ParameterizedCommand, Event) line: 169 WorkbenchKeyboard.executeCommand(Binding, Event) line: 468 WorkbenchKeyboard.press(List, Event) line: 786 WorkbenchKeyboard.processKeyEvent(List, Event) line: 885 WorkbenchKeyboard.filterKeySequenceBindings(Event) line: 567 WorkbenchKeyboard.access$3(WorkbenchKeyboard, Event) line: 508 WorkbenchKeyboard$KeyDownFilter.handleEvent(Event) line: 123 EventTable.sendEvent(Event) line: 84 Display.filterEvent(Event) line: 1253 Thread [main] (Suspended) WidgetMethodHandler.execute(ExecutionEvent) line: 157 HandlerProxy.execute(ExecutionEvent) line: 293 E4HandlerProxy.execute(IEclipseContext) line: 55 NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not available [native method] NativeMethodAccessorImpl.invoke(Object, Object[]) line: 48 DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: 37 Method.invoke(Object, Object...) line: 600 MethodRequestor.callMethod(Method, Object[]) line: 57 MethodRequestor.execute() line: 32 InjectorImpl.invokeUsingClass(Object, Class<?>, Class<Annotation>, Object, AbstractObjectSupplier, boolean) line: 180 InjectorImpl.invoke(Object, Class<Annotation>, Object, AbstractObjectSupplier) line: 161 ContextInjectionFactory.invoke(Object, Class<Annotation>, IEclipseContext, Object) line: 104 HandlerServiceImpl.executeHandler(ParameterizedCommand) line: 114 KeyBindingDispatcher.executeCommand(ParameterizedCommand, Event) line: 260 KeyBindingDispatcher.press(List, Event) line: 456 KeyBindingDispatcher.processKeyEvent(List, Event) line: 506 KeyBindingDispatcher.filterKeySequenceBindings(Event) line: 339 KeyBindingDispatcher.access$0(KeyBindingDispatcher, Event) line: 285 KeyBindingDispatcher$KeyDownFilter.handleEvent(Event) line: 74 EventTable.sendEvent(Event) line: 84 Display.filterEvent(Event) line: 1253
We're also using a WMH for the 'Navigator' view.
We aren't adding the CopyToClipboardAction as a handler in the correct place. That probably means our setGlobalActionHandler(*) isn't using the correct incantation to make it available to the new command framework. PW
(In reply to comment #2) > We aren't adding the CopyToClipboardAction as a handler in the correct place. > That probably means our setGlobalActionHandler(*) isn't using the correct > incantation to make it available to the new command framework. public void setGlobalActionHandler(String actionId, IAction handler) { // FIXME compat setGlobalActionHandler: needs to actually register // handlers actions.put(actionId, handler); } Well, this looks suspect.
Created attachment 166566 [details] ActionBars patch v1 The code was there but it was being incorrectly overridden it seems.
(In reply to comment #3) > // FIXME compat setGlobalActionHandler: needs to actually register > // handlers > > Well, this looks suspect. That would definitely be the incorrect way of registering them ... PW
(In reply to comment #4) > Created an attachment (id=166566) [details] > ActionBars patch v1 Fix released to HEAD.
