Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 311070 - [doc] FacetModuleCoreSupport.getDynamicWebProjectVersion impl doesn't match javadoc
Summary: [doc] FacetModuleCoreSupport.getDynamicWebProjectVersion impl doesn't match j...
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: jst.jsp (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 RC1   Edit
Assignee: Nitin Dahyabhai CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-29 13:22 EDT by Andrew McCulloch CLA
Modified: 2011-04-28 01:01 EDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew McCulloch CLA 2010-04-29 13:22:26 EDT 
Build Identifier: M20100211-1343

org.eclipse.jst.jsp.core.internal.util.FacetModuleCoreSupport#getDynamicWebProjectVersion(IProject) has the following documentation "@return -1 if the project does not have the JST Web facet" however upon inspection of the code it appears to return version 2.5 if the project is null, not a faceted project, or does not contain the jst.web facet.  Note the implementation appears in org.eclipse.jst.jsp.core.internal.util.FacetModuleCoreSupportDelegate.

I am not sure what the intention is so this may just be a javadoc bug but I would assume -1 should be returned instead of 2.5 on a project that doesn't have the jst.web facet.

Reproducible: Always

Steps to Reproduce:
1. Create a Java project (not a faceted project)
2. Call org.eclipse.jst.jsp.core.internal.util.FacetModuleCoreSupport#getDynamicWebProjectVersion(IProject)
3. Verify a return value of 2.5f
Comment 1 Rakesh CLA 2011-01-06 05:35:50 EST 
Documentation of FacetModuleCoreSupport has already been changed.Change in documentation of FacetModuleCoreSupportDelegate is still required.
Comment 2 Nitin Dahyabhai CLA 2011-04-28 01:01:23 EDT 
Updated.