Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 311066 - No API change should be reported for org.eclipse.jface.viewers.StructuredViewerInternals$AssociateListener#void filteredOut(Object)
Summary: No API change should be reported for org.eclipse.jface.viewers.StructuredView...
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 RC1   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-29 13:04 EDT by Olivier Thomann CLA
Modified: 2011-01-26 14:34 EST (History)
2 users (show)

See Also:
darin.eclipse: review+


Attachments
Proposed fix + regression tests (15.80 KB, text/plain)
2010-04-29 13:04 EDT, Olivier Thomann CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2010-04-29 13:04:54 EDT
Created attachment 166526 [details]
Proposed fix + regression tests

From I20100428-1300 build result, this method is reported as an API addition.
This is wrong.
The interface member type StructuredViewerInternals$AssociateListener is tagged as @noimplement and @noextend and its enclosing type is tagged as @noextend. Since the interface is protected, there is no way this new method can be used as API.
So we should not report the corresponding delta in case the visibility is API.
Comment 1 Darin Wright CLA 2010-04-30 10:57:30 EDT
Marking as RC1.
Comment 2 Darin Wright CLA 2010-05-07 15:41:50 EDT
+1
Comment 3 Olivier Thomann CLA 2010-05-10 10:28:32 EDT
Released for 3.6RC1.