Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 311049 - The action "Create Java Query Implementation Class" is missing
Summary: The action "Create Java Query Implementation Class" is missing
Status: CLOSED FIXED
Alias: None
Product: MoDisco
Classification: Modeling
Component: Infrastructure (show other bugs)
Version: 0.8.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.8.0 M7   Edit
Assignee: Nicolas Bros CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-29 11:46 EDT by Gregoire Dupe CLA
Modified: 2011-05-23 09:23 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gregoire Dupe CLA 2010-04-29 11:46:58 EDT 
Hi,

Here is a scenario to reproduce a UI problem.

In a new workspace: 
 - Create a MoDisco project
 - Create a QuerySet file
 - Add a Java query (New child > Java Model Query)
 - Right click on the Java query -> you don’t get the action "Create Java Query Implementation Class"
 - Right click on the Java query and select "Execute query"
 - Right click on the Java query -> you get the action "Create Java Query Implementation Class"

Regards,
Grégoire
Comment 1 Nicolas Bros CLA 2010-04-29 13:44:28 EDT 
This is a sneaky bug: CreateJavaQueryImplClassAction is filtered by a filter named "isWorkspaceQuery", implemented by WorkspaceQueryFilter, which is created through WorkspaceQueryFilterFactory, which is an adaptable for a JavaModelQuery defined in the plugin.xml of infra.query.ui.

Problem is, WorkspaceQueryFilter is not always loaded because infra.query.ui, as any Eclipse plug-in, is lazy-loaded, and adapters don't trigger bundle loading.
Comment 2 Nicolas Bros CLA 2010-04-29 14:28:21 EDT 
Fixed in revision 2177, by referencing WorkspaceQueryFilter explicitely in QueryEditor (to force it to be loaded), and moving WorkspaceQueryFilter and WorkspaceQueryFilterFactory to query.core, because query.editor cannot have a dependency on query.ui, since the opposite dependency already exists.
Comment 3 Hugo Bruneliere CLA 2010-10-01 13:32:45 EDT 
Bug fixed.