Community
Participate
Working Groups
Build Identifier: 20090920-1017 When I use the standard plugin_customization.ini file that allow to override the preference default defined by plugins, it is ignored by subversive plugin. I analyzed the Subversive code and found out why and produce a patch. Reproducible: Always Steps to Reproduce: 1. Create an eclipse product (I can post one) 2. Add a plugin_customization.ini at the root of the product plugin with the following line: org.eclipse.team.svn.ui/preference.autopropertiesautoproperties=MQ\=\=;YWJj;YWJj 3. Run the product 4. Look at Window > Preference > Team > SVN > Properties Configuration 5. It remains empty (it should have an automatic property checked with abc as a File Name and abc as Properties
Created attachment 166482 [details] Patch with the correction The issue is due to the initilization of the default prefrences from the SVNTeamUIPlugin's start method directly. Such initilization should be done using the org.eclipse.core.runtime.preferences initializer extension point. When done this way the preferenceCustomization is taken in account after the Subversive default properties are set. Otherwise the preferenceCustomization will be taken in account firstly, then overridden during org.eclipse.team.svn.ui plugin startup (the default preference initilisation is called here).
Created attachment 166485 [details] Eclipse product for test Here is an Eclipse test product to do the validation. Launch the "Lauch Eclipise Test Product.launch" in a workspace with the subversive plugins checked out and with the patch applied. (Futher target plateform might have to be defined.)
I don't mean to be rude or pushy, but do you have any idea when you could simply review the patch. It's a quite simple modification (as many look like, I agree). Thanks Yann
Yann, thanks a lot for provided patch, I'll review it when I finish with some important tasks I'm doing now.
Yann, I applied patch. Thanks a lot.
Thanks to you, Igor.
Hi Igor, I couldn't found my correction in org.eclipse.team.svn.ui_0.7.9.I20100512-1900.jar. In which version will it be released ?
Sorry, I just see now your comment is was on 2010-05-27, and the last release from 2010-05-12. So we'll just wait a bit more...
