Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 310612 - [Markers] Quick fix wizard should not let the user finish if nothing has been selected
Summary: [Markers] Quick fix wizard should not let the user finish if nothing has been...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.7 M3   Edit
Assignee: Dani Megert CLA
QA Contact: Hitesh CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 326000
  Show dependency tree
 
Reported: 2010-04-27 08:00 EDT by Remy Suen CLA
Modified: 2010-10-26 05:59 EDT (History)
3 users (show)

See Also:

Attachments
Patch v01 (2.07 KB, patch)
2010-10-13 08:06 EDT, Hitesh CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-04-27 08:00:46 EDT 
1. Create a simple class.

public class Test {
	
	private int i;

}

2. You should get a warning about the unused field 'i'.
3. Open the 'Problems' view, you should see the warning there.
4. Select the warning > Ctrl+1
5. Click 'Deselct All'. The 'Finish' button should be disabled.
Comment 1 Remy Suen CLA 2010-04-27 08:01:41 EDT 
Forgot to say I'm testing on I20100426-0852.
Comment 2 Eric Moffatt CLA 2010-04-27 15:52:47 EDT 
Remy, any guess as to whom to send this to ? Even thought he class is in markers it doesn't feel (to me) like a markers problem.
Comment 3 Dani Megert CLA 2010-10-13 07:35:09 EDT 
Fixed in org.eclipse.ui.internal.views.markers.QuickFixPage rev. 1.8.
Comment 4 Hitesh CLA 2010-10-13 08:06:32 EDT 
Created attachment 180757 [details]
Patch v01

Patch applied to CVS HEAD. Phew !! That was fast !!
Comment 5 Hitesh CLA 2010-10-13 08:10:12 EDT 
I am not sure if it was fixed prior to the last comment. The isPageComplete() was overridden to always return a true.
Comment 6 Hitesh CLA 2010-10-13 08:22:07 EDT 
Dani, I happened to pick the same bug a while ago. I did see a clash while trying to release the patch - I thought you were working on one of the other bugs. However, I have released the patch non-clashingly... I think I'll release any other changes I have once you are done.
Comment 7 Dani Megert CLA 2010-10-13 08:37:10 EDT 
(In reply to comment #6)
> Dani, I happened to pick the same bug a while ago. I did see a clash while
> trying to release the patch - I thought you were working on one of the other
> bugs. However, I have released the patch non-clashingly... I think I'll release
> any other changes I have once you are done.

Yes, please wait until I'm done with bug 326000 completely. Note that the code you "fixed" already worked.
Comment 8 Deepak Azad CLA 2010-10-26 05:59:43 EDT 
Verified for 3.7M3 on Linux-GTK with I20101025-1800.