Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 310481 - [Wizards] New file wizard seems to have a grammatically incorrect error message
Summary: [Wizards] New file wizard seems to have a grammatically incorrect error message
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M7   Edit
Assignee: Szymon Ptaszkiewicz CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-26 11:57 EDT by Remy Suen CLA
Modified: 2011-03-22 13:21 EDT (History)
2 users (show)

See Also:


Attachments
Patch (1018 bytes, patch)
2010-11-24 10:26 EST, Szymon Ptaszkiewicz CLA
Szymon.Brandys: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-04-26 11:57:34 EDT
I20100425-2000

1. File > New > Other... > General > File
2. Select a folder (if one hasn't been preselected).
3. Enter a name for the file.
4. Delete your input.
5. An error message appears stating "Names cannot be empty.". Only one text field is blank, it seems the word "name" should not have to be pluralized.
Comment 1 Prakash Rangaraj CLA 2010-04-28 04:29:01 EDT
The message is not from UI, but from Resources :LocationValidator.validateName()
Comment 2 Szymon Ptaszkiewicz CLA 2010-11-24 10:26:01 EST
Created attachment 183770 [details]
Patch
Comment 3 John Arthorne CLA 2010-12-08 13:53:09 EST
FWIW the current message seems fine to me. It's the difference between a general statement (file names cannot be empty), versus a specific statement (the name of *this* file cannot be empty).
Comment 4 Szymon Brandys CLA 2011-01-04 06:38:56 EST
(In reply to comment #3)
Right. This particular message is right. The problem is lack of consistency in messages among platform wizards. For instance:
1) File > New > Other > General > Project. If the name is entered and deleted we get "Project name must be specified" message
2) File > New > Other > General > Folder, we get "The 'folder' name is empty." message.
3) File > New > Other > General > File, we get "Names cannot be empty." error.

If you try to rename a folder in Project Explorer using "Refactor > Rename" we get no message. However the rename in Package Explorer shows "This is an invalid name for a file or folder" error.

I think we may find lots of such inconsistencies. We should try to address at least these in Platform.
Comment 5 Szymon Brandys CLA 2011-03-22 13:21:16 EDT
Fixed.