Community
Participate
Working Groups
Created attachment 166011 [details] Switch JPA facet requirements to a group Please see bug 234383 (JPA: Remove dependence on utility facet) and bug 308125 (Facets: Supporting more flexible groups) for background. The facet framework is adding support for more flexible group enablement. Once bug 308125 is released I'm proposing the attached patch be applied to JPT for two reasons: * The JPT plugin.xml will be slightly cleaner in it's own right, as it allows a single group to be defined and reused by both versions of the JPT facet. * Defining a group in this way allows adopters to extend the group when they know of another facet that will work with JPT. For instance, an adopter who has a flexible project with a new facet could add itself to the group. I've tested the change as well as extending it, but you may want to change the label or description.
Created attachment 166146 [details] proposed patch Changed a few minor things from the previous patch. group id: jpa-requires -> jpa-prereqs externalized the label string altered the description Incidentally, the error message that appears when the group requirement isn't met is: "JPA 2.0 requires any member of <group name>", which kinda makes it hard to name the group. Maybe it should read "JPA 2.0 requires any member of *the group* "<group name>"." Does that sound a bit less awkward?
I've tested this with head code (have issues downloading i builds at work for some reason) but I'll test with the latest i build tomorrow and try to get this in ASAP.
Thanks, Paul. Appreciated. I've opened bug 310561 to follow up on the facet group error message text.
committed for m7
verified in WTP S-3.2.0M7-20100429210436
Verified in RC1 as well, working great. Thanks.
