Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 309731 - [TMF] Make coalesced requests more generic
Summary: [TMF] Make coalesced requests more generic
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: LinuxTools (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Francois Chouinard CLA
QA Contact: Francois Chouinard CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 301615
  Show dependency tree
 
Reported: 2010-04-19 15:13 EDT by Francois Chouinard CLA
Modified: 2022-01-13 14:53 EST (History)
0 users

See Also:

Attachments
ITmfDataRequest patch (130.91 KB, patch)
2010-04-19 15:16 EDT, Francois Chouinard CLA 		fchouinard: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Francois Chouinard CLA 2010-04-19 15:13:04 EDT 
The TmfEventProvider methods are parameterized with TmfDataRequest and a check is made later to determine which actual type of event we are dealing with.

This check is performed directly against a concrete type, which is not such a great idea since extended types are not taken into consideration (this breaks isCompleted() among others).

The simple, obvious solution is to parameterize ITmfDataRequest instead. It simplifies code and is future proof.
Comment 1 Francois Chouinard CLA 2010-04-19 15:16:04 EDT 
Created attachment 165340 [details]
ITmfDataRequest patch

- Used ITmfDataRequest instead of TmfDataRequest
- Added a bunch of unit tests
- Fixed a problem with component registering/deregistering
Comment 2 Francois Chouinard CLA 2010-04-19 15:18:04 EDT 
Patch committed
Comment 3 Francois Chouinard CLA 2010-04-19 15:18:26 EDT 
Comment on attachment 165340 [details]
ITmfDataRequest patch

Patch committed
Comment 4 Francois Chouinard CLA 2010-07-08 10:35:11 EDT 
Released in a previous delivery.