Community
Participate
Working Groups
Created attachment 164921 [details] patch with the fix described An IResourceManagerSubmitJobErrorEvent currently is not diplayed in an error dialog by the AbstractParallelLaunchConfigurationDelegate. The reason for this is that the state handling has an incorrect condition which creates a race condition between the "waitFor()" method of the JobSubmission class and the "submit()" method. The error is at line 235 of the AbstractParallelLaunchConfigurationDelegate.java file: while (!monitor.isCanceled() && status != JobSubStatus.SUBMITTED) { Since the submission is initialized to this state, only in the event that an ERROR or COMPLETED event is processed by the ResourceManagerListener before the return of the waitFor() method will the code behave properly. In most cases, however, these events arrive after that method has returned. Line 235 should be: while (!monitor.isCanceled() && status == JobSubStatus.SUBMITTED) SUMBITTED here really means "not yet submitted", with the COMPLETED state representing SUBMITTED. For the sake of clarity, the enumeration at line 123 has also been changed to: public enum JobSubStatus {UNSUBMITTED, SUBMITTED, ERROR}.
Al, please confirm that: 1) This code contains no cryptography. 2) The code has been developed from scratch (i.e. without incorporating content from elsewhere or relying on the intellectual property of others). 3) All code in the contribution is licensed under the EPL.
(In reply to comment #1) > Al, please confirm that: > > 1) This code contains no cryptography. > > 2) The code has been developed from scratch (i.e. without incorporating content > from elsewhere or relying on the intellectual property of others). > > 3) All code in the contribution is licensed under the EPL. I, Albert L. Rossi, confirm that: 1) This code contains no cryptography. 2) The code has been developed from scratch (i.e. without incorporating content from elsewhere or relying on the intellectual property of others). 3) All code in the contribution is licensed under the EPL.
I think I can see the declaration. Al, you need to fix how you add comments in bugzilla, it looks like newlines are getting escaped somewhere. Committed to HEAD.
