Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 309067 - Java EE 6 annotation not created for description
Summary: Java EE 6 annotation not created for description
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.servlet (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M7   Edit
Assignee: Kaloyan Raev CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: JavaEE6
Keywords:
: 310453 (view as bug list)
Depends on: 252618
Blocks:
  Show dependency tree
 
Reported: 2010-04-13 22:59 EDT by Carl Anderson CLA
Modified: 2013-02-11 14:58 EST (History)
2 users (show)

See Also:
cbridgha: review+

Attachments
patch (66.35 KB, patch)
2010-04-26 09:45 EDT, Kaloyan Raev CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carl Anderson CLA 2010-04-13 22:59:30 EDT 
In the new Servlet wizard, one of the fields the user can enter is the description.  This is part of the new Java EE 6 annotations allowed for @WebServlet, but CreateServletTemplateModel.getJavaEE6AnnotationParameters() does not include the description= part of the annotation, and thus that information is lost.

The same goes for Filters and Listeners.
Comment 1 Carl Anderson CLA 2010-04-13 23:05:46 EDT 
This also applies to the initialization parameters- their descriptions are also lost in the annotations.
Comment 2 Kaloyan Raev CLA 2010-04-26 09:45:19 EDT 
Created attachment 166076 [details]
patch

This patch reworks the generation of Servlet 3.0 annotations - now they are generated in a similar way like the EJB 3.0 bean annotations. 

They are several benefits:
  - the description attributes are not lost
  - when they is lots of metadata, the annotations are formatted in a readable way. 

The patch covers both the @WebServlet and @WebFilter annotations.
Comment 3 Kaloyan Raev CLA 2010-04-26 09:46:00 EDT 
Chuck, please review this patch for 3.2 M7.
Comment 4 Kaloyan Raev CLA 2010-04-26 10:59:03 EDT 
*** Bug 310453 has been marked as a duplicate of this bug. ***
Comment 5 Chuck Bridgham CLA 2010-04-27 23:06:40 EDT 
approve - this is a big change.. I tested some and it seemed ok.
Comment 6 Kaloyan Raev CLA 2010-04-28 04:02:58 EDT 
Committed to HEAD and released to build.
Comment 7 Kaloyan Raev CLA 2010-04-28 04:03:08 EDT 
Closing