Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 309042 - [TMF] Cleanup loose ends
Summary: [TMF] Cleanup loose ends
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: LinuxTools (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Francois Chouinard CLA
QA Contact: Francois Chouinard CLA
URL:
Whiteboard:
Keywords:
Depends on: 316047
Blocks: 301610
  Show dependency tree
 
Reported: 2010-04-13 16:01 EDT by Francois Chouinard CLA
Modified: 2022-01-13 14:53 EST (History)
0 users

See Also:


Attachments
Improved code coverage (JUnits) (149.57 KB, patch)
2010-04-13 16:06 EDT, Francois Chouinard CLA
fchouinard: iplog-
Details | Diff
Experiment cleanup (14.63 KB, patch)
2010-04-15 13:47 EDT, Francois Chouinard CLA
fchouinard: iplog-
Details | Diff
JUnit+CodeCoverage_1 (211.54 KB, patch)
2010-05-03 13:47 EDT, Francois Chouinard CLA
fchouinard: iplog-
Details | Diff
TmfEventsView progress monitor (3.06 KB, patch)
2010-06-07 13:54 EDT, Francois Chouinard CLA
fchouinard: iplog-
Details | Diff
Updated version # (16.60 KB, patch)
2010-10-26 17:00 EDT, Francois Chouinard CLA
fchouinard: iplog-
Details | Diff
Graduate to Java 6 (232.83 KB, patch)
2010-10-26 17:50 EDT, Francois Chouinard CLA
fchouinard: iplog-
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Francois Chouinard CLA 2010-04-13 16:01:27 EDT
A general bug for code cleanup (equals(), hashCode(), toString(), code coverage, etc).
Comment 1 Francois Chouinard CLA 2010-04-13 16:06:16 EDT
Created attachment 164773 [details]
Improved code coverage (JUnits)

- Improved code TMF code coverage
- Fixed a number of issues with equals(), hashCode(), toString()
- Removed clone() from the event model
Comment 2 Francois Chouinard CLA 2010-04-13 16:11:01 EDT
Comment on attachment 164773 [details]
Improved code coverage (JUnits)

Patch committed.
Comment 3 Francois Chouinard CLA 2010-04-15 13:47:29 EDT
Created attachment 165000 [details]
Experiment cleanup

Update on TmfExperiment based on Patrick's comments, suggestions and code.
Comment 4 Francois Chouinard CLA 2010-04-15 13:50:37 EDT
Comment on attachment 165000 [details]
Experiment cleanup

Patch committed.
Comment 5 Francois Chouinard CLA 2010-05-03 13:47:08 EDT
Created attachment 166812 [details]
JUnit+CodeCoverage_1

Augmented TMF JUnit code coverage (more to come). Fixed a few loose ends.
Patch commited.
Comment 6 Francois Chouinard CLA 2010-06-07 13:14:26 EDT
Updated the plugin versions.
Comment 7 Francois Chouinard CLA 2010-06-07 13:54:57 EDT
Created attachment 171308 [details]
TmfEventsView progress monitor

When switching experiment, the table view is cleared for the new data.

When a large experiment was opened (> 1M events) the clearing time can be quite noticeable.

This patch adds a progress monitor to the signal handler so the user has a clue of what is going on.

Note: the final solution for this problem is to get rid of the virtual events table and implement the thing ourselves. Everything is reasonably straighforward except the scrolling *back*.
Comment 8 Francois Chouinard CLA 2010-06-07 13:55:14 EDT
Comment on attachment 171308 [details]
TmfEventsView progress monitor

Fix committed
Comment 9 Andrew Overholt CLA 2010-06-07 14:56:05 EDT
Please revert the changes to the version numbers.  It's too late in the game for us to be changing the version numbers.  This will have to be a 0.6.1 change (bug #316047).
Comment 10 Francois Chouinard CLA 2010-06-09 07:27:32 EDT
Reverted.
Comment 11 Francois Chouinard CLA 2010-10-26 17:00:52 EDT
Created attachment 181781 [details]
Updated version #
Comment 12 Francois Chouinard CLA 2010-10-26 17:05:48 EDT
Comment on attachment 181781 [details]
Updated version #

Committed to Indigo.
Comment 13 Francois Chouinard CLA 2010-10-26 17:50:19 EDT
Created attachment 181788 [details]
Graduate to Java 6
Comment 14 Francois Chouinard CLA 2010-10-27 11:53:24 EDT
Comment on attachment 181788 [details]
Graduate to Java 6

Committed to Indigo
Comment 15 Francois Chouinard CLA 2011-07-22 15:13:16 EDT
Delivered with 0.8