Comment 1 Chris Aniszczyk 2010-04-09 12:28:49 EDT

On top of an icon, we need to...

1) Help page 
2) A editable combo box for the destination just like the other export wizards
(with delayed path checking)
3) The page should not open with a warning.

Comment 2 Curtis Windatt 2010-04-09 14:25:44 EDT

Just got an NPE the first time I used the wizard:
java.lang.NullPointerException
at org.eclipse.pde.internal.ui.wizards.exports.ExportActiveTargetJob.run(ExportActiveTargetJob.java:117)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

The wizard itself needs to use the target wizard image in it's banner, in addition to the export decoration on the icon in the export type selection wizard.

Comment 3 Ian Bull 2010-04-09 14:38:29 EDT

(In reply to comment #2)
> Just got an NPE the first time I used the wizard:
> java.lang.NullPointerException
> at
> org.eclipse.pde.internal.ui.wizards.exports.ExportActiveTargetJob.run(ExportActiveTargetJob.java:117)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
> 

:-(, Boourns to the NPE.  

Just for some context. This is happening when we try to get the (DS) component that acquires all the relevant p2 services needed to export the metadata.  There are few things I would like to do here:
1. Remove the use of DS. I implemented this component last year, and looking at it now, it's not a very good use of DS.  We should just get the agent and acquire the services that way. I can make that change.

2. If we really can't get the agent (not sure why this would happen in the IDE, but clearly it has), continue the export without writing the metadata. We should likely log this problem, but the tool still has use without writing the metadata.

thoughts?

Comment 4 Ian Bull 2010-04-09 14:45:30 EDT

Actually, I take that back. It looks like Chris already removed the use of DS. I'm not sure how this is supposed to work now. I'll work with Chris on this.

Comment 5 Curtis Windatt 2010-04-23 13:03:38 EDT

If this feature is not going to get some major polish work done on it, I think it should be reverted.  I'm inclined to remove it for M7 before the feature freeze.  It is certainly not in a good enough state to be included in the new and noteworthy.

In addition to the NPE and UI issues, this wizard needs to do a much better job explaining to the user what it does.

Comment 6 Chris Aniszczyk 2010-04-23 13:04:34 EDT

I'll put this on my list for today to polish then.

Comment 7 Ian Bull 2010-04-23 15:04:18 EDT

Created attachment 165955 [details]
Patch to fix the NPE.

This patch fixes the NPE.

However, something seems to have changed with the profile (at least in self hosted mode).  When we query the profile (the profile used to represent the target) we don't get any IUs.

Comment 8 Chris Aniszczyk 2010-04-25 22:50:19 EDT

Thanks Ian, looking to get a patch in by Monday with UI polish items.

Comment 9 Chris Aniszczyk 2010-04-26 11:05:15 EDT

Created attachment 166090 [details]
org.eclipse.pde.ui.patch

Fixes to the target export wizard.

Comment 10 Chris Aniszczyk 2010-04-26 11:05:47 EDT

I will open another bug for the help, we should add it during the RC cycle.