Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 307761 - [ui] Numpad enter key doesn't activate p2 combo box
Summary: [ui] Numpad enter key doesn't activate p2 combo box
Status: VERIFIED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M7   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-31 12:47 EDT by Remy Suen CLA
Modified: 2010-04-26 12:43 EDT (History)
2 users (show)

See Also:

Attachments
RepositorySelectionGroup patch v1 (1.30 KB, patch)
2010-04-13 12:15 EDT, Remy Suen CLA 		susan: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-03-31 12:47:06 EDT 
I20100312-1448

1. Help > Install New Software...
2. Ctrl+V some update site in it.
3. Hit the numpad enter key. Nothing happens.
4. Keep trying, still nothing.
5. Hit the regular enter key, stuff happens.
Comment 1 Pascal Rapicault CLA 2010-03-31 14:51:28 EDT 
Is your keyboard plugged ;-) ?
Comment 2 Remy Suen CLA 2010-03-31 15:50:10 EDT 
(In reply to comment #1)
> Is your keyboard plugged ;-) ?

I think so. I tried hitting the key in this Bugzilla input box and it inserted new lines into it.
Comment 3 Remy Suen CLA 2010-03-31 16:14:08 EDT 
Line 130+ of RepositorySelectionGroup:

public void keyPressed(KeyEvent e) {
  if (e.keyCode == SWT.CR)
    addRepository(false);
}
Comment 4 Remy Suen CLA 2010-04-13 12:15:17 EDT 
Created attachment 164743 [details]
RepositorySelectionGroup patch v1

I am hit by this bug every time I use p2.
Comment 5 Susan McCourt CLA 2010-04-14 22:38:09 EDT 
thanks, Remy, assigning to myself for M7
Comment 6 Susan McCourt CLA 2010-04-15 18:39:02 EDT 
fixed in HEAD >20100415
Comment 7 Susan McCourt CLA 2010-04-26 12:38:56 EDT 
Remy, can you verify?
(I'm being lazy because I'm not sitting near my "full keyboard" PC right now.)
Comment 8 Remy Suen CLA 2010-04-26 12:43:09 EDT 
(In reply to comment #7)
> Remy, can you verify?
> (I'm being lazy because I'm not sitting near my "full keyboard" PC right now.)

Your wish is my command.

Verified with I20100425-2000 on Windows XP.
Comment 9 Remy Suen CLA 2010-04-26 12:43:16 EDT 
Whoops.