Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 307471 - None of fragment related tests are actually running
Summary: None of fragment related tests are actually running
Status: CLOSED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.6 M7   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-30 01:07 EDT by Alin Dreghiciu CLA
Modified: 2010-03-30 23:41 EDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (14.02 KB, patch)
2010-03-30 02:02 EDT, Alin Dreghiciu CLA 		pascal: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alin Dreghiciu CLA 2010-03-30 01:07:22 EDT 
Build Identifier: 

The tests from FragmentTest and MultipleIUAndFragmentTest are actually not running. Even if all of them pass, that is only due to the way the tests are written, meaning that they do assertions only when there are IUs in solved plan. But, as there is no IU asked to be solved in the request, there is no iu in the plan so the for loops result in no cycle, so the assertions are not run.

Reproducible: Always
Comment 1 Alin Dreghiciu CLA 2010-03-30 02:02:53 EDT 
Created attachment 163361 [details]
Proposed patch

The patch fixes the unit tests.
Comment 2 Ian Bull CLA 2010-03-30 10:22:18 EDT 
(In reply to comment #1)
> Created an attachment (id=163361) [details]
> Proposed patch
> 
> The patch fixes the unit tests.

Do they actually pass once fixed :-).
Comment 3 Alin Dreghiciu CLA 2010-03-30 13:26:16 EDT 
(In reply to comment #2)
I change them completely . They still test same thing but a bit different.
Comment 4 Pascal Rapicault CLA 2010-03-30 23:40:57 EDT 
Fixed in HEAD.