Community
Participate
Working Groups
Build Identifier: 20090920-1017 Replace Old Style Do Loops Refactoring: This refactoring replace old style do loop formats whith a more structured construction by adding a END DO statement . Reproducible: Always
Created attachment 163318 [details] Replace Old Style Do Loop Refactoring Patch
Thanks a lot, Mariano. Can you please confirm that 1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, 2. you have the right to contribute the code to Eclipse, and 3. you have included the EPL license header in all source files? (To do this, you can just add a comment to this bug stating, "I confirm that..." and basically repeat these three points. Thanks.)
Also, I quickly skimmed your patch. Everything looks good, except for two minor things. 1. On the files you wrote entirely yourself (e.g., ReplaceOldStyleDoLoopRefactoring), please change the copyright notice at the top of the file. Instead of "Copyright (c) 2010 University of Illinois at Urbana-Champaign and others", it should either read "Copyright (c) 2010 Mariano Mendez and others" or "Copyright (c) 2010 Universidad Nacional de la Plata and others," depending on whether you "own" the code that you wrote or whether you were paid to do it by your university. 2. Please also add a brief summary comment to the JavaDoc for each new class, above the line "@author Mariano Mendez", stating briefly what it does. Thanks a lot. Jeff
I confim that I wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, I confim that I have the right to contribute the code to Eclipse, and I confim that I have included the EPL license header in all source files?
Created attachment 163903 [details] replace Old Style Do Loops Refactoring new patch here is the pacth with the changes
Created attachment 166215 [details] The new one with copyright modification this one has the right copyright. Mariano
Targeting this for 7.0 or 6.1. We'll need to submit a CQ for legal approval... maybe do this and some other refactorings all at once...
Created attachment 170207 [details] the patch according new photran 6 structure the new patch with changes for hellios done .
CQ 4177 submitted
Created attachment 171189 [details] New code compliant with eclipse Helios rc2 (message bundles)
Hi Mariano, I've been in contact with the IP team. They will be contacting Alejandra regarding copyright issues. Also, the copyright headers you have now look like this: +/******************************************************************************* + * Copyright (c) 2010 University of Mariano Mendez and others. + * All rights reserved. This program and the accompanying materials + * are made available under the terms of the Eclipse Public License v1.0 + * which accompanies this distribution, and is available at + * http://www.eclipse.org/legal/epl-v10.html + * + * Contributors: + * UIUC - Initial API and implementation + *******************************************************************************/ They would like you to make the following changes: 1. The first line should read "Copyright (c) 2010 Mariano Mendez and others." (There is no University of Mariano Mendez!) 2. The last line should read "Mariano Mendez - Initial API and implementation" Please revise the patch accordingly, and I'll submit the revised version to the IP team. Thanks.
Created attachment 172180 [details] legal issue fixed
Thanks. I attached the revised patch to the CQ. Sharon will process the CQ as soon as she receives confirmation from your University that the copyright belongs to you.
Note to self: There will be some duplication between this and Matt's control flow code, since both need to collect and map the statement labels in a procedure. I should pull that functionality up into ScopingNode or some other superclass.
The CQ was approved. I will try to get this into CVS soon.
Esfar, could you please convert the test suite for this refactoring to be marker-based and then attach a revised patch? Thanks.
Created attachment 174449 [details] Marker based test suite for Replace Old Style Do Loops refactoring Note: Test 5 does not pass due to a minor issue involving the reindenter (and its' behavior concerning the keyword "continue"). This is NOT an issue with the refactoring itself.
Created attachment 174452 [details] (NEW) Marker-based test suite for Replace Old Style Do Loop Refactoring Patch that corrects an issue with the name of the suite file from the (now) obsolete patch. All other notes/comments from the last patch still apply.
Thanks. Esfar, for your test suite code, can you please confirm that 1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others (except for code from Mariano's original tests), 2. you have the right to contribute the code to Eclipse, and 3. you have included the EPL license header in all source files?
(In reply to comment #19) > Thanks. Esfar, for your test suite code, can you please confirm that > > 1. you wrote 100% of the code without incorporating content from elsewhere or > relying on the intellectual property of others (except for code from Mariano's > original tests), > > 2. you have the right to contribute the code to Eclipse, and > > 3. you have included the EPL license header in all source files? Yes, 1. I wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others (except for code from Mariano's original tests), 2. I have the right to contribute code to Eclipse, and 3. I have included the EPL license header in all source files
Created attachment 174687 [details] Revised patch with new test suite, merge conflicts resolved
Hi Mariano, I ran into a small problem. The changes to the LoopReplacer are reordering statements in a couple of our test files. I will send those to you in e-mail. I attached a revised patch to this bug. It is the same as your patch, except we converted the test suite to be marker-based, and some CVS merge conflicts have been resolved. Could you please delete your local copy of this refactoring, then update from CVS, apply the *revised* patch I just attached to this bug, and take a look at this? Thanks! Jeff
I will Mariano
Created attachment 176513 [details] Bugs Fixed patch
Patch committed to CVS. Thanks, Mariano! Could you please add a screenshot and brief instructions to the Photran 7 Advanced Features manual at http://wiki.eclipse.org/PTP/photran/documentation/photran7advanced Thanks!
Patch is in CVS; closing bug
