307291 – object checker must permit leading '0' in mode

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 307291 - object checker must permit leading '0' in mode

Summary: object checker must permit leading '0' in mode

Status:	RESOLVED FIXED

Alias:	None

Product:	JGit
Classification:	Technology
Component:	JGit (show other bugs)
Version:	unspecified
Hardware:	All All

Importance:	P3 major with 2 votes (vote)
Target Milestone:	3.4
Assignee:	Shawn Pearce
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-03-27 15:34 EDT by Shawn Pearce
Modified:	2014-03-12 23:20 EDT (History)
CC List:	4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Shawn Pearce

2010-03-27 15:34:59 EDT

Tree objects whose subtree pointers use a leading '0' in the mode field must be permitted.  Currently these are being rejected.  But a discussion on the Git mailing list [1] has determined that there are at least 16 such trees in the official Linux kernel history, and GitHub has estimated at least 100 customer projects contain the same problem.

[1] http://thread.gmane.org/gmane.comp.version-control.git/143288
[2] http://support.github.com/discussions/repos/2566-strange-warning-from-fsck-and-github-repo-using-too-much-diskspace

Comment 1 Brad Larson

2011-02-01 19:18:13 EST

FWIW, it appears that the kernel is clean and this problem only exists in repositories from GitHub [1].

[1] http://article.gmane.org/gmane.comp.version-control.git/143352

Comment 2 md

2011-03-21 11:58:25 EDT

This issue is resulting in serious headaches for us. Our Webdesign team had been using the GitHub online Editor for some time and therefore nearly all of our repositories have some commits with leading '0'. Completely rewriting active repositories with a bout a dozen developers looks like a PIA so it would be very helpful if JGit (and in our case gerrit) would be able to handle this "extension" of the format created by GitHub.

Comment 3 Jonathan Nieder

2014-03-12 18:41:48 EDT

https://git.eclipse.org/r/23224

Comment 4 Shawn Pearce

2014-03-12 23:19:58 EDT

Supported now by setting fsck.allowLeadingZeroFileMode to true.