Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 306733 - Patch to sdm_message_tcpip.c
Summary: Patch to sdm_message_tcpip.c
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: Debug SDM (show other bugs)
Version: 3.0.1   Edit
Hardware: All Linux
: P3 critical (vote)
Target Milestone: ---   Edit
Assignee: Greg Watson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-22 11:45 EDT by Jie Jiang CLA
Modified: 2010-05-31 18:59 EDT (History)
1 user (show)

See Also:

Attachments
Change sdm_message_tcpip.c to enable binding in a port range (746 bytes, patch)
2010-03-22 11:45 EDT, Jie Jiang CLA 		g.watson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jie Jiang CLA 2010-03-22 11:45:44 EDT 
Created attachment 162684 [details]
Change sdm_message_tcpip.c to enable binding in a port range

In ptp_3.0_branch and HEAD, there is a bug in org.eclipse.ptp.debug.sdm/src/impl/sdm_message_tcpip.c, funtion sdm_parent_port_bind().

Line 151 in this function loops until parentport < parentbaseport + MAX_PORT_INCREMENT. However, the increment of parentport is not used in the next loop as desired.  Actually, the new parentport must be assigned to the sockaddr_info.sin_port before the next bind.

Please see the detail modification in the attached patch.
Comment 1 Greg Watson CLA 2010-03-22 14:47:05 EDT 
Applied to 3.0 and HEAD.