Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 306631 - [Theming][Shell] Make blocker overlay for modal shells themeable
Summary: [Theming][Shell] Make blocker overlay for modal shells themeable
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.3   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.3 M7   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-21 07:00 EDT by Ralf Sternberg CLA
Modified: 2010-04-01 09:38 EDT (History)
0 users

See Also:

Attachments
fix (49.56 KB, patch)
2010-03-31 08:13 EDT, Tim Buschtoens CLA 		no flags Details | Diff
Updated fix (49.62 KB, patch)
2010-03-31 13:03 EDT, Rüdiger Herrmann CLA 		no flags Details | Diff
advanced fix (60.43 KB, patch)
2010-04-01 06:24 EDT, Tim Buschtoens CLA 		holger.staudacher: iplog+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Sternberg CLA 2010-03-21 07:00:50 EDT 
This would allow for a lightbox effect without any extra code.

Introduce a CSS element like "Shell-Overlay" with properties background-color and opacity. The default opacity would be 0, which effectively hides the overlay.
Comment 1 Tim Buschtoens CLA 2010-03-31 08:13:15 EDT 
Created attachment 163520 [details]
fix

Also contains client tests.
Comment 2 Holger Staudacher CLA 2010-03-31 09:17:04 EDT 
With your patch the overlay works if you set it global. But if you use variants it doesn't work. Additional the patch should consider that a modal shell can also open a modal shell.
Comment 3 Rüdiger Herrmann CLA 2010-03-31 13:03:45 EDT 
Created attachment 163550 [details]
Updated fix

The above patch with an updated element description for Shell-Display-Overlay.
Please use this patch as a basis for further changes.
Comment 4 Tim Buschtoens CLA 2010-04-01 06:24:48 EDT 
Created attachment 163624 [details]
advanced fix

Based on Rüdigers updates, now also copies states *after* the shell has been opend. Tests also check for multiple-shells behavior.
Comment 5 Holger Staudacher CLA 2010-04-01 09:38:11 EDT 
Patch works. Changes are in CVS HEAD now.