Community
Participate
Working Groups
EjbJar Discoverer Model, Discoverer and Tests 1. I am the author of 100% of the content 2. I have the rights to donate the content to Eclipse under the EPL 3. I have already provided the filled Employer Consent Forms to the Foundation
Created attachment 162410 [details] org.eclipse.gmt.modisco.jee.ejbjar.discoverer EjbJar Discoverer
Created attachment 162411 [details] org.eclipse.gmt.modisco.jee.ejbjar.discoverer.tests EjbJar Discoverer Tests
Created attachment 162413 [details] org.eclipse.gmt.modisco.jee.ejbjar EjbJar Discoverer Tests
Hi Nicolas, Thank you for this contribution. Here are some details which will require to export again the artefacts. These details are also relevant for equivalent contributions 306355/306360. Since 306355/306360/306365 propose equivalent features and are subject to IP discussion during CQ process, i propose you to fix the artefacts only for this contribution for the time being. all components : - The modisco.common.core plugin was renamed into modisco.infra.common.core. Please update your workspace and modify references - component naming : better remove "Generic" prefix - build.properties : include "about.html" and "resources" folders - Messages.java : keep the original generated classes for internationalization NLS framework metamodel components : - add copyrights to .ecore/.genmodel/bundle.properties/messages.properties - plugin.properties : use rather the OSGI-INF bundle.properties and delete the redundant "pluginName" and "providerName" tests components : - rename the projects/packages/bundle-name with ".discoverer.tests" The code contained no jdt nor checkstyle warnings :-) Thanks in advance. Fabien.
Created attachment 162968 [details] org.eclipse.gmt.modisco.jee.ejbjar New version with requested modifications
Created attachment 162969 [details] org.eclipse.gmt.modisco.jee.ejbjar.discoverer New version with requested modifications
Created attachment 162970 [details] org.eclipse.gmt.modisco.jee.ejbjar.discoverer.tests New version with requested modifications
The code has been successfully commited within a new feature called jee. Waiting for non reg tests to be installed on hudson -> depends on 313738. Fabien.
The bug 313738 has been fixed. Non reg tests work fine now.
Contribution successfully integrated.