Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 305847 - Plug-in import wizard: "Delete Plug-in Projects" doesn't delete filtered plug-ins any more
Summary: Plug-in import wizard: "Delete Plug-in Projects" doesn't delete filtered plug...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.6 M7   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-15 09:35 EDT by Markus Keller CLA
Modified: 2010-03-20 09:21 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2010-03-15 09:35:42 EDT
I20100312-1448

Was OK in M5, probably a regression from bug 300507.

Steps:
- import plug-ins as binary, choose the 3 that match the filter "jface"
- import plug-ins as binary again, choose "Existing Unshared"
=> "Delete Plug-in Projects" dialog shows all 3

- enter "text" as filter string
- click OK

=> Expected: Since I didn't uncheck any project, all the projects should be replaced with the new version.
=> Was: Only the visibly checked project is replaced. The filtered ones are not deleted and thus imported a second time with a version qualifier.
Comment 1 Curtis Windatt CLA 2010-03-17 15:04:19 EDT
Fixed in HEAD.  The code was calling viewer. getCheckedElements which returns children of collapsed ancestors, but not filtered items.  Calling getCheckedLeafElements (part of the PDE filtered tree) returns the correct result.
Comment 2 Pascal Rapicault CLA 2010-03-20 09:21:19 EDT
*** Bug 306375 has been marked as a duplicate of this bug. ***