Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 305711 - [Help] Content preference page needs UI polish
Summary: [Help] Content preference page needs UI polish
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M7   Edit
Assignee: Jim Perry CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-12 12:35 EST by Chris Goldthorpe CLA
Modified: 2010-03-17 17:29 EDT (History)
1 user (show)

See Also:
ChrisAustin: review-


Attachments
Screenshot (25.07 KB, image/png)
2010-03-12 12:36 EST, Chris Goldthorpe CLA
no flags Details
Screenshot - 'Windows Xp' Theme (102.54 KB, image/jpeg)
2010-03-17 06:12 EDT, Snehasish Paul CLA
no flags Details
Screenshot - Windows Explorer - 'IBM' Theme (189.04 KB, image/jpeg)
2010-03-17 06:28 EDT, Snehasish Paul CLA
no flags Details
Patch fixing gray sliver on the preference page (2.92 KB, patch)
2010-03-17 11:19 EDT, Jim Perry CLA
ChrisAustin: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Goldthorpe CLA 2010-03-12 12:35:49 EST
I20100311-1616

If the Help/Content preference page is set to "Include local help only" the table titles show up as being mostly white but there is a gray sliver at the right of the title. What's more that sliver of gray remains when I click one of the other radio buttons.

Recommendations
1. Make the title gray when disabled
2. Make the background of the title the same color as the title
Comment 1 Chris Goldthorpe CLA 2010-03-12 12:36:44 EST
Created attachment 161904 [details]
Screenshot
Comment 2 Chris Goldthorpe CLA 2010-03-12 12:37:29 EST
Jim, can you fix this?
Comment 3 Snehasish Paul CLA 2010-03-17 06:12:10 EDT
Created attachment 162257 [details]
Screenshot - 'Windows Xp' Theme

In SWT, table's look-n-feel would be similar to that of Operating System.
In Windows Xp/Window Classic theme, table header looks fine.
Comment 4 Snehasish Paul CLA 2010-03-17 06:28:10 EDT
Created attachment 162258 [details]
Screenshot - Windows Explorer - 'IBM' Theme

IBM theme --> Table header always looks whitish with gray background in both Eclipse and Windows Explorer.

In Eclipse Preferences dialog, go to:
Ant->Editor->Templates
Install/Update->Available Software Sites
Java->Compiler->Task Tags
All looks the same, whitish table header with gray background.
Comment 5 Jim Perry CLA 2010-03-17 11:19:07 EDT
Created attachment 162300 [details]
Patch fixing gray sliver on the preference page

Added fix for using ColumnWeightData which provides a minimum column size but is resized automatically based on the header width.

This patch does not include a fix for making the text gray for the remote help options that are not selected.  I will upload a new patch with this fix.
Comment 6 Jim Perry CLA 2010-03-17 12:55:07 EDT
The header not gray when the SWT table is disabled is an SWT theme issue rather than a bug in Eclipse.  In SWT, the table's look-n-feel would be similar to that of Operating System.  In Windows Xp/Window Classic theme, the table header looks fine.  However, with the IBM theme, the table header has the white coloring.  There are a few instances of an SWT table in Eclipse, and all show the same behavior.  There is no convenient API for accessing the Table header directly and applying styles to it.  Table.setBackground() does not impact the header.  Also, Display.setBackground() and Shell.setBackground() do not affect the table.

This appears to be working as designed.  We could make the header not visible if the table is disabled, but we may not want to do that from a usability standpoint.
Comment 7 Chris Goldthorpe CLA 2010-03-17 13:55:04 EDT
Chris Austin, can you review and commit Jim's patch?
Comment 8 Chris Austin CLA 2010-03-17 15:57:54 EDT
Added 2010 to the Copyright for RemoteICViewer.java.  Otherwise, looks good, patch committed to HEAD.
Comment 9 Chris Austin CLA 2010-03-17 16:08:21 EDT
Closing bug as Fixed.