Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 305569 - external.xpt is not build from source
Summary: external.xpt is not build from source
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.7 RC2   Edit
Assignee: Grant Gayed CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-11 14:02 EST by Benjamin Drung CLA
Modified: 2011-05-19 11:02 EDT (History)
4 users (show)

See Also:
eclipse.felipe: review+
Silenio_Quarti: review+

Attachments
eclipse-swt-compile-xpt.patch (1.10 KB, patch)
2010-03-17 06:58 EDT, Benjamin Drung CLA 		no flags Details | Diff
eclipse-swt-compile-xpt.patch (1.10 KB, patch)
2010-03-17 07:09 EDT, Benjamin Drung CLA 		grant_gayed: iplog+
Details | Diff
revised patch (1.22 KB, patch)
2011-05-18 17:15 EDT, Grant Gayed CLA 		no flags Details | Diff
addition patch that's needed for compiling on Solaris SPARC (1.35 KB, patch)
2011-05-19 11:02 EDT, Grant Gayed CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Drung CLA 2010-03-11 14:02:57 EST 
Build Identifier: M20100211-1343

eclipse-build wants to build eclipse from source. The source contains the precompiled external.xpt file. We want to remove it from the source tarball and it should be build. On Debian/Ubuntu it can be generated by running

$(pkg-config --variable=sdkdir libxul | sed "s/-devel//")/xpidl -m typelib -I $(pkg-config --variable=idldir libxul)/unstable/ -e external.xpt external.idl

Reproducible: Always
Comment 1 Benjamin Drung CLA 2010-03-17 06:58:34 EDT 
Created attachment 162264 [details]
eclipse-swt-compile-xpt.patch

Attached a patch that compiles the .xpt file if it does not exit. The code should work at least on Debian, Ubuntu, and Fedora.
Comment 2 Benjamin Drung CLA 2010-03-17 07:09:42 EDT 
Created attachment 162265 [details]
eclipse-swt-compile-xpt.patch

Updated patch (the previous had problems to find the correct file to patch).
Comment 3 Alexander Kurtakov CLA 2010-05-27 11:16:13 EDT 
This patch is not intended for eclipse-build so it seems like it will be missing eclipse-build Helios release.
Comment 4 Benjamin Drung CLA 2010-06-10 20:27:32 EDT 
The patch for eclipse-build is attached to bug #304112.
Comment 5 Andrew Overholt CLA 2010-08-04 10:02:42 EDT 
Removing blocker for eclipse-build since we've worked around it there.
Comment 6 Chris Aniszczyk CLA 2011-05-02 10:34:43 EDT 
Grant, can you look at this for 3.7 RC1?

It's a small patch and prevents us from patching Eclipse locally.
Comment 7 Grant Gayed CLA 2011-05-18 17:15:21 EDT 
Created attachment 196051 [details]
revised patch
Comment 8 Grant Gayed CLA 2011-05-18 17:17:40 EDT 
Comment on attachment 162265 [details]
eclipse-swt-compile-xpt.patch

adding iplog+ to original patch because final patch is largely based on it
Comment 9 Grant Gayed CLA 2011-05-18 17:18:27 EDT 
fixed > 20110518
Comment 10 Andrew Overholt CLA 2011-05-18 17:19:00 EDT 
Thanks for taking care of this, Grant!
Comment 11 Grant Gayed CLA 2011-05-19 11:02:01 EDT 
Created attachment 196124 [details]
addition patch that's needed for compiling on Solaris SPARC