Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 305497 - ChangeEncodingAction's dialog has unnecessary whitespace
Summary: ChangeEncodingAction's dialog has unnecessary whitespace
Status: CLOSED DUPLICATE of bug 188275
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-11 09:41 EST by Remy Suen CLA
Modified: 2010-03-15 05:27 EDT (History)
1 user (show)

See Also:

Attachments
Screenshot depicting the problem in question. (7.62 KB, image/gif)
2010-03-11 09:41 EST, Remy Suen CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-03-11 09:41:08 EST 
Created attachment 161745 [details]
Screenshot depicting the problem in question.

Please see attached.
Comment 1 Remy Suen CLA 2010-03-11 09:44:11 EST 
I see now that it's for the error message (if you enter random text in the combo control). Are users even supposed to enter things in there? Should it be read-only?

If they are allowed to enter things and the space is for the error message, perhaps a StatusDialog would be more appropriate?
Comment 2 Dani Megert CLA 2010-03-15 05:27:12 EDT 
> Are users even supposed to enter things in there?
Yes: the SDK only offers a default set of known encodings and hence needs to allow adding new ones by typing them in.

> Should it be read-only?
And hence no ;-)

>perhaps a StatusDialog would be more appropriate?
I agree from the UI/user standpoint but there's currently no easy way to (re-) use a field editor in a status dialog: it wants a dialog page to show the status.
Comment 3 Dani Megert CLA 2010-03-15 05:27:48 EDT 
.

*** This bug has been marked as a duplicate of bug 188275 ***