Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 305207 - [Sync View][Apply Patch] Where is "Remove from View" action?
Summary: [Sync View][Apply Patch] Where is "Remove from View" action?
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M7   Edit
Assignee: Pawel Pogorzelski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-09 13:14 EST by Tomasz Zarna CLA
Modified: 2010-04-12 05:58 EDT (History)
0 users

See Also:

Attachments
Quick fix v01 (3.48 KB, patch)
2010-03-09 13:18 EST, Tomasz Zarna CLA 		no flags Details | Diff
mylyn/context/zip (1.51 KB, application/octet-stream)
2010-03-09 13:18 EST, Tomasz Zarna CLA 		no flags Details
Patch_v02 (3.42 KB, patch)
2010-04-12 05:52 EDT, Pawel Pogorzelski CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2010-03-09 13:14:14 EST 
I20100307-2000

I don't know how in the world did that happen, but apparently the fix for bug 301243 caused the "Remove from View" action to disappear. This also applies to accompanying "Restore Removed Items" action in view's drop down. The fix could be tweaked a little bit at the same time, so removing the "Schedule" action takes place when a participant doesn't adapt to IRefreshable.class[1].

[1] as in org.eclipse.team.internal.ui.synchronize.actions.RefreshActionContribution.initialize(ISynchronizePageConfiguration)
Comment 1 Tomasz Zarna CLA 2010-03-09 13:18:43 EST 
Created attachment 161493 [details]
Quick fix v01
Comment 2 Tomasz Zarna CLA 2010-03-09 13:18:47 EST 
Created attachment 161494 [details]
mylyn/context/zip
Comment 3 Tomasz Zarna CLA 2010-03-09 13:32:43 EST 
Pawel, please review the patch. Note that the action still cannot be applied to any node when in "Patch Contents" model, but I guess this can be addressed by a separate bug.
Comment 4 Pawel Pogorzelski CLA 2010-04-12 05:52:41 EDT 
Created attachment 164543 [details]
Patch_v02

Tomasz, I updated your patch to HEAD. It looks good, I didn't find any problems related to it.
Comment 5 Pawel Pogorzelski CLA 2010-04-12 05:58:24 EDT 
Patch_v02 in HEAD. Marking as FIXED. Problems with the action in Patch Content model are tracked on bug 308811.