Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 305070 - CCombo should not throw away event.doit of forwarded events
Summary: CCombo should not throw away event.doit of forwarded events
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4.2+   Edit
Assignee: Bogdan Gheorghe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 294706 (view as bug list)
Depends on:
Blocks: 290555
  Show dependency tree
 
Reported: 2010-03-08 17:16 EST by Boris Bokowski CLA
Modified: 2010-05-13 17:10 EDT (History)
6 users (show)

See Also:

Attachments
snippet (3.87 KB, text/plain)
2010-03-08 17:17 EST, Boris Bokowski CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Boris Bokowski CLA 2010-03-08 17:16:30 EST 
One example if this is: CCombo forwards key events from its drop down list to key listeners on the combo, but creates a new event object for this. If a listener sets event.doit on this new event object to false, CCombo should set event.doit to false on the original event too.

I'll attach a snippet.
Comment 1 Boris Bokowski CLA 2010-03-08 17:17:01 EST 
Created attachment 161374 [details]
snippet
Comment 2 Bogdan Gheorghe CLA 2010-03-08 18:14:53 EST 
Fixed in HEAD > 20100308
Comment 3 Lakshmi P Shanmugam CLA 2010-03-18 08:11:07 EDT 
*** Bug 294706 has been marked as a duplicate of this bug. ***
Comment 4 Anthony Hunter CLA 2010-04-23 11:56:25 EDT 
Hi Team, would it be possible to move this fix from HEAD back into 3.4.2 stream? We would then be able to patch the existing Ganymede SR2 release with this fix.

We have a customer requesting this fix. They feel it is of a critical nature for their application and need a fix in the Ganymede stream.

I have asked the EMF team as well for Bug 290555 .
Comment 5 Bogdan Gheorghe CLA 2010-04-26 11:29:37 EDT 
Hi Anthony - we can do this but you should request this through IES (Steve Francisco).
Comment 6 Silenio Quarti CLA 2010-05-13 14:23:19 EDT 
This patch has been released in the R3_4_maintenance branch.
Comment 7 Ed Merks CLA 2010-05-13 14:43:26 EDT 
Note that this change in the 3.4 stream will produce highly undesirable behavior in EMF's property view cell editors without the changes made in EMF's 2.6 stream.
Comment 8 Anthony Hunter CLA 2010-05-13 14:55:12 EDT 
(In reply to comment #7)
> Note that this change in the 3.4 stream will produce highly undesirable
> behavior in EMF's property view cell editors without the changes made in EMF's
> 2.6 stream.

Over to EMF Bug 290555 then :-)
Comment 9 Boris Bokowski CLA 2010-05-13 15:12:53 EDT 
(In reply to comment #6)
> This patch has been released in the R3_4_maintenance branch.

Is the fix in R3_5_maintenance as well?
Comment 10 Ed Merks CLA 2010-05-13 15:29:58 EDT 
I expressed my concern in https://bugs.eclipse.org/bugs/show_bug.cgi?id=290555 that it seems odd to fix things in 3.6/2.6 and 3.4/2.4 but not in 3.5/2.5. Changing this in 3.5 forces a fix for 2.5 and we haven't yet produced a maintenance stream for 2.5...
Comment 11 Silenio Quarti CLA 2010-05-13 16:16:57 EDT 
(In reply to comment #9)
> (In reply to comment #6)
> > This patch has been released in the R3_4_maintenance branch.
> Is the fix in R3_5_maintenance as well?

No, should it be there?
Comment 12 Boris Bokowski CLA 2010-05-13 16:29:38 EDT 
(In reply to comment #11)
> > Is the fix in R3_5_maintenance as well?
> 
> No, should it be there?

It's up to you really, but I agree with Ed that it seems very odd to have a fix in the 3.4 maintenance stream and in HEAD but not in the 3.5 maintenance stream.
Comment 13 Dave Steinberg CLA 2010-05-13 17:10:25 EDT 
We (both EMF and IBM) are not asking for it in the 3.5 stream. So, it's up to you. As Ed points out, it does the opposite of help us, since EMF's not planning to put our fix in 2.5.