Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 304710 - [eclipse-build] [debian] Partial patches for building org.eclipse.osgi.services from source
Summary: [eclipse-build] [debian] Partial patches for building org.eclipse.osgi.servic...
Status: RESOLVED WORKSFORME
Alias: None
Product: Linux Tools
Classification: Tools
Component: eclipse-build (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Niels Thykier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 304706
Blocks: 304112
  Show dependency tree
 
Reported: 2010-03-04 12:33 EST by Niels Thykier CLA
Modified: 2012-04-12 06:14 EDT (History)
3 users (show)

See Also:

Attachments
Updates properties and callback script for osgi-services (made by akurtakov) (2.47 KB, patch)
2010-03-04 12:37 EST, Niels Thykier CLA 		no flags Details | Diff
Updates the bootstrap build order. (920 bytes, patch)
2010-03-04 12:38 EST, Niels Thykier CLA 		no flags Details | Diff
osgi-services.patch (4.79 KB, patch)
2010-07-10 20:01 EDT, Benjamin Drung CLA 		no flags Details | Diff
Test patch for building without o.e.e.io and o.osgi.service.io (1.20 KB, patch)
2011-05-07 07:19 EDT, Niels Thykier CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Niels Thykier CLA 2010-03-04 12:33:29 EST 
Build Identifier: 

Hi

Bringing you 2 patches that will build org.eclipse.osgi.services from source. It is currently blocked by #304706, but I will attach them now anyway in the hope it is fixed soon.

~Niels


Reproducible: Always
Comment 1 Niels Thykier CLA 2010-03-04 12:37:05 EST 
Created attachment 160981 [details]
Updates properties and callback script for osgi-services (made by akurtakov)

First patch:

akurtakov's patch with a minor correction.

~Niels
Comment 2 Niels Thykier CLA 2010-03-04 12:38:27 EST 
Created attachment 160982 [details]
Updates the bootstrap build order.

Updates pdebuild.xml so org.eclipse.osgi.services is built before the plugins needing it.

~Niels
Comment 3 Benjamin Drung CLA 2010-07-10 20:01:11 EDT 
Created attachment 173958 [details]
osgi-services.patch

Attached the latest version of the osgi-services.patch. After applying the patch you need to regenerate eclipse-build-generatedScripts.tar.bz2.
Comment 4 Benjamin Drung CLA 2010-07-10 20:20:32 EDT 
To compile the source, you have to modify the SDK source tarball:

cd eclipse/plugins/org.eclipse.osgi.services
unzip src.zip -d src
rm src.zip
Comment 5 Andrew Overholt CLA 2010-07-14 11:51:01 EDT 
Is this still blocked by bug #304706?
Comment 6 Benjamin Drung CLA 2010-07-14 12:18:56 EDT 
Bug #304706 is still open, but we work around it by symlinking javax.microedition.io (patch from comment #3).
Comment 7 Niels Thykier CLA 2011-05-07 07:18:31 EDT 
As I suggested on IRC I might have a better/easier solution for this.

As far as I can tell, we do not need the plugin org.eclipse.equinox.io and it is the only consumer of the files in org.osgi.service.io (in o.e.osgi.services).  As far as I have tested this myself, I would like review testing on this before I push this to the eclipse-build repository.

For the test, I will create a patch that removes the unused files as a part of the applyPatches target (saves you a rebuild of the SDK tarball); for the actual implementation, we should of course remove these files when creating the SDK tarball.


Fedora people: I would appreciate if you also could test that these changes does not break your srpm.

If this works, we do not need the javax.microedition.io files to rebuild org.osgi.services/o.e.osgi.services.

~Niels
Comment 8 Niels Thykier CLA 2011-05-07 07:19:20 EDT 
Created attachment 195003 [details]
Test patch for building without o.e.e.io and o.osgi.service.io
Comment 9 Krzysztof Daniel CLA 2012-04-12 06:14:21 EDT 
we already build org.eclipse.osgi.services.