Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 304653 - [Webapp][Bidi] Breadcrumbs in Arabic topics display nodes in wrong order
Summary: [Webapp][Bidi] Breadcrumbs in Arabic topics display nodes in wrong order
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.4.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.8 M1   Edit
Assignee: platform-ua-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-04 04:55 EST by Leo CLA
Modified: 2011-07-19 17:53 EDT (History)
4 users (show)

See Also:


Attachments
Expected orders (31.58 KB, image/jpeg)
2010-03-04 05:01 EST, Leo CLA
no flags Details
Unexpected orders (38.39 KB, image/jpeg)
2010-03-04 05:01 EST, Leo CLA
no flags Details
sample doc plug-in (171.25 KB, application/octet-stream)
2010-03-05 03:16 EST, Leo CLA
no flags Details
patch (1.74 KB, patch)
2011-07-12 11:59 EDT, Heba Aboulmagd CLA
cgold: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leo CLA 2010-03-04 04:55:16 EST
Build Identifier: 3.4.2

The breadcrumbs in the Arabic topics appear with the root node in the center. The child nodes appear to the right in English in the left-to-right direction. The child ndes appear to the left in Arabic in (I presume) the right-to-left direction. As a result, the order of the breadcrumbs is incorrect.

Reproducible: Always
Comment 1 Leo CLA 2010-03-04 05:01:15 EST
Created attachment 160915 [details]
Expected orders
Comment 2 Leo CLA 2010-03-04 05:01:54 EST
Created attachment 160916 [details]
Unexpected orders
Comment 3 Chris Goldthorpe CLA 2010-03-04 16:43:10 EST
Is this a problem only when there is a mixture of languages in the breadcrumb path? Do you see the same result in all browsers?
Comment 4 Leo CLA 2010-03-05 03:16:19 EST
Created attachment 161084 [details]
sample doc plug-in

Here is the doc plug-in for reference to reproduce this issue.
Comment 5 Chris Goldthorpe CLA 2010-03-05 12:23:00 EST
The problem is that the html generated for breadcrumbs is a series of anchors separated by '>' characters wrapped up in a single div. If the titles are all left to right or all right to left I believe it displays correctly. The most convenient solution would be to change org.eclipse.help.webapp/advanced/breadcrumbs.css in the arabic language, however without trying this I don't know if it would work. Something like 

.help_breadcrumbs {
	direction : rtl;
}

Can you experiment with the css to see if it's possible to solve the problem just by fixing the css in the language pack. If that does not work then it will require changing the generated html and possibly using a graphic rather than a character to represent the '>'. Hopefully we do not have to do that. 

I don't have time to investigate this bug right now but if you can find a solution and create a patch I would be happy to test and commit it.

Does this problem show up in all browsers or only certain ones?
Comment 6 Mohamed El-Kholy CLA 2011-06-12 04:33:34 EDT
I am trying to fix this bug but I don't understand how to reproduce it, may you please list detailed steps to get the screen shots shown? also may you please attach the html files shown in the screen shots , thanks on advance
Comment 7 Heba Aboulmagd CLA 2011-07-12 11:59:51 EDT
Created attachment 199509 [details]
patch

This is a known Bidi problem with Complex Expressions. Complex expressions refer to date with well defined internal structure or syntax. During display of such data the syntax should be preserved. When mixed BIDI and non-BIDI data is used as part of such expressions, the syntax is not preserved.

Please find the proposed fix with attached patch. However I do not know how to test the attached "sample doc plug-in". Can you please, guide me how test it?.

Thanks
Comment 8 Chris Goldthorpe CLA 2011-07-19 17:43:05 EDT
I tested the patch using the attached plug-in and passing the -rtl flag to Eclipse. I verified that without the patch the help page looks like "Unexpected orders" and with the patch it looks like "Expected orders".

I will commit the patch for Eclipse 3.8/4.2. Let me know if you also need this fix in 3.7.1.
Comment 9 Chris Goldthorpe CLA 2011-07-19 17:53:07 EDT
Patch committed to CVS HEAD, Fixed.