Community
Participate
Working Groups
Build Identifier: 20100204-1618 Hi MoDisco team, In order to occupy my long winter nights, I transformed the MoDisco browser to an editor. In attachment, the patch for this. In this patch: - I modified the EcoreBrowser class - I changed PropertySheetPage to ExtendedPropertySheetPage. - We didn't use PropertySourceAdapterFactory but AdapterFactoryContentProvider to fuel the PropertySheetPage. - EcoreBrowser class implements IEditingDomainProvider and IGotoMarker - I implemented methods save saveAs isDirty ... (They were not implemented) - I modified the BrowserActionBarContributor class - BrowserActionBarContributor class extends EditingDomainActionBarContributor - I added "New Child" and "New Sibling" menus - I added a default menu to provide eclipse with delete, copy, undo, redo, ... functions - I modified the WorkspaceChangeListener class - I modified the Messages class and Messages.properties file. So with this patch the following actions become available: - Edit a model - Add an object to the model - Delete an object from the model - Undo, redo, refresh To finish, with the MoDisco browser we can see details of a selected "AttributeItem" in the property view. Now, we only show the details of containing "ModelElementItem" when we select an "AttributeItem" . Best regards, Nicolas Payneau Reproducible: Always
Created attachment 160623 [details] Patch transforming the MoDisco browser to an editor
(In reply to comment #1) > Created an attachment (id=160623) [details] > Patch transforming the MoDisco browser to an editor Hi, I discovered an error after the patch contributed. This error appears in some cases when selecting item in the browser. This error located in the class org.eclipse.gmt.modisco.infra.browser.editors.BrowserActionBarContributor at line 231. We have to check if the object has a resource before retrieving the URI. Best regards, Nicolas Payneau
Hi Nicolas, Please, could you make the usual confirmations via this bug and attach to it the latest version of the patch to be actually integrated? I will create the corresponding CQ as soon as possible. Best regards, Hugo
(In reply to comment #3) > Hi Nicolas, > > Please, could you make the usual confirmations via this bug and attach to it > the latest version of the patch to be actually integrated? > > I will create the corresponding CQ as soon as possible. > > Best regards, > > Hugo Hi Hugo, I confirm that you have the latest version of the patch. I confirm that 1. I, Nicolas Payneau, authored 100% of the content 2. I have the rights to donate the content to Eclipse under the EPL 3. I have already provided the filled Employer Consent Forms to the Foundation Best regards, Nicolas
Corresponding CQ 3845 has been created.
The CQ has been validated (very quickly thanks to Sharon). I'm going to integrate the patch. Hugo
Nicolas, I have some problems applying your patch: e.g. it removes the PropertySourceAdapterFactory class which is still required, etc. Note that I'm using the latest version of the org.eclipse.gmt.modisco.infra.browser plug-in (sources) from the MoDisco SVN trunk. Please, could you check from your development workspace that you don't have such issues? Regards, Hugo
Don't bother with it. Gabriel made a refactoring, and I already made modifications to the patch. So, leave it to me.
OK Nicolas. So I consider the patch as being applied. Hugo
