Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 304119 - [Webapp] Help system should register separate aliases for "/basic" and "/advanced"
Summary: [Webapp] Help system should register separate aliases for "/basic" and "/adva...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.7 M6   Edit
Assignee: Chris Goldthorpe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 333282 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-02-26 17:27 EST by Martin Oberhuber CLA
Modified: 2012-09-06 03:26 EDT (History)
8 users (show)

See Also:

Attachments
Patch (845 bytes, patch)
2011-02-09 17:27 EST, Chris Goldthorpe CLA 		no flags Details | Diff
Improved patch (1.31 KB, patch)
2011-02-09 18:48 EST, Chris Goldthorpe CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2010-02-26 17:27:52 EST 
+++ This bug was initially created as a clone of Bug #303898 +++

Build ID: Eclipse 3.6m5

As per ChrisG' on bug 303898 comment 8:

Any bundle that registers a resource alias of '/' can clash with the help system. I could make the problem less likely to occur by declaring separate aliases for /basic and /advanced.

This seems to be a good idea, so I thought I'd request it.
Comment 1 Chris Goldthorpe CLA 2011-02-09 17:27:54 EST 
Created attachment 188634 [details]
Patch

I looked into this a while ago and wanted to replace the resource alias of "/" with separate aliases for /advanced and /basic. That did not work because it caused index.jsp to load as a text file instead of being processed as a jsp. Adding /basic and /advanced without removing "/" still makes sense I think and will likely solve the problem in Bug 333282.
Comment 2 Chris Goldthorpe CLA 2011-02-09 17:29:01 EST 
Patch applied to HEAD
Comment 3 Chris Goldthorpe CLA 2011-02-09 18:48:13 EST 
Created attachment 188637 [details]
Improved patch

There was a problem with the previous patch, I have committed this one in it's place.
Comment 4 Chris Goldthorpe CLA 2011-02-21 18:54:42 EST 
*** Bug 333282 has been marked as a duplicate of this bug. ***