This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 303431 - remove CommonColors.CONTEXT_ACTIVE
Summary: remove CommonColors.CONTEXT_ACTIVE
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: dev   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 3.4   Edit
Assignee: Frank Becker CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 199345
  Show dependency tree
 
Reported: 2010-02-21 05:34 EST by Frank Becker CLA
Modified: 2010-02-25 21:51 EST (History)
3 users (show)

See Also:

Attachments
commited patch (3.65 KB, patch)
2010-02-21 05:44 EST, Frank Becker CLA 		no flags Details | Diff
mylyn/context/zip (1.55 KB, application/octet-stream)
2010-02-21 05:44 EST, Frank Becker CLA 		no flags Details
commitet patch (3.03 KB, patch)
2010-02-21 09:58 EST, Frank Becker CLA 		no flags Details | Diff
mylyn/context/zip (1.74 KB, application/octet-stream)
2010-02-21 09:58 EST, Frank Becker CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Becker CLA 2010-02-21 05:34:40 EST 
Use CommonThemes.COLOR_TASK_ACTIVE instead.

The only place where it is used is TaskElementLabelProvider and the other colors use CommonThemes
Comment 1 Frank Becker CLA 2010-02-21 05:44:34 EST 
Created attachment 159690 [details]
commited patch
Comment 2 Frank Becker CLA 2010-02-21 05:44:38 EST 
Created attachment 159691 [details]
mylyn/context/zip
Comment 3 Frank Becker CLA 2010-02-21 09:58:04 EST 
Created attachment 159707 [details]
commitet patch

Sorry,

I did not  include all the files in my first commit.
Comment 4 Frank Becker CLA 2010-02-21 09:58:08 EST 
Created attachment 159708 [details]
mylyn/context/zip
Comment 5 Steffen Pingel CLA 2010-02-21 15:04:15 EST 
Good point, Frank. I agree that CommonColors.COLOR_TASK_ACTIVE should be handled differently but I am not sure that it needs to be exposed in a preference. 

Mik, can you clarify what the purpose of the color is?

As far as I remember it is a bit lighter than black since active elements are shown bold so the color makes them stand out slightly less. Shouldn't the color be derived from another color in that case?

I have added this to next weeks meeting agenda to get feedback.
Comment 6 Steffen Pingel CLA 2010-02-25 21:51:51 EST 
We'll leave the color preference for now and review later whether it can be removed since landmarks and other bold decorations do not use this color which makes the Task List coloring slightly inconsistent with the platform.