Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 303371 - Protocol comes through as space character instead of HTTP when protocol preference is space
Summary: Protocol comes through as space character instead of HTTP when protocol prefe...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 4.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M6   Edit
Assignee: Jim Perry CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-19 16:13 EST by Jim Perry CLA
Modified: 2010-02-19 19:29 EST (History)
1 user (show)

See Also:

Attachments
Patch for this space character issue (1.09 KB, patch)
2010-02-19 16:16 EST, Jim Perry CLA 		cgold: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Perry CLA 2010-02-19 16:13:48 EST 
Build Identifier: eclipse-SDK-I20100216-2200-win32

With the addition of HTTPS support, a protocol preference was added.  There is a case where if the protocol preference is blank, the ICs are assigned the space character for a protocol instead of the default (HTTP)

Reproducible: Always

Steps to Reproduce:
1. Launch Eclipse with a remote IC added (leave protocol preference blank)
2. Goto Window -> Preferences -> Help -> Content, and see that the protocol preference is blank
3.
Comment 1 Jim Perry CLA 2010-02-19 16:16:53 EST 
Created attachment 159620 [details]
Patch for this space character issue

Patch which creates a fresh array of the append value (HTTP) in this case, if a preference is blank.

Since the .split method returns a String [1] for space, this was throwing us off.  If space is encountered, we want to create a String[0] and let the code update this array for us (which was already in place).
Comment 2 Chris Goldthorpe CLA 2010-02-19 19:29:33 EST 
Patch committed to HEAD, Fixed