Comment 1 Steffen Pingel 2010-02-24 19:18:15 EST

Created attachment 160143 [details]
screenshot

Comment 2 Steffen Pingel 2010-02-24 19:19:55 EST

Thanks Eike. I have added your request as a discussion item to this week's meeting agenda to gather some feedback from other Mylyn committers.

Additional discussion can be found in the news group: http://www.eclipse.org/forums/index.php?t=msg&th=162605&start=0&

Comment 3 Steffen Pingel 2010-02-25 13:22:29 EST

Points brought up by Shawn:

* Disable trim by default and make it implement IWorbenchTrim
* Retain extensibility for toolbar contributions
* Make the trim work vertically
* Where would it be placed by default?

Comment 4 Steffen Pingel 2010-02-26 14:24:32 EST

I am scheduling for 3.4. It's still unclear how we are going to proceed but the goal is to either promote the trim widget or implement a solution that provides equivalent functionality.

Comment 5 Steffen Pingel 2010-05-26 01:08:50 EDT

Moving unresolved feature requests to 3.5.

Comment 6 Steffen Pingel 2011-02-08 20:49:28 EST

I committed a small change that hides the parent toolbar of the contribution if the trim is disabled. This fixes the layout flickering on workbench startup on Gtk. Shawn, can you check if it also works on Windows? I would love to move the trim contribution to proper in 3.5.

Comment 7 Steffen Pingel 2011-02-09 01:06:34 EST

Created attachment 188563 [details]
move trim contribution to tasks.ui

Comment 8 Steffen Pingel 2011-02-09 01:06:35 EST

Created attachment 188564 [details]
mylyn/context/zip

Comment 9 Steffen Pingel 2011-02-09 01:07:39 EST

Created attachment 188565 [details]
preference

Comment 10 Steffen Pingel 2011-02-09 01:09:16 EST

I have committed the patch to head. The trim is now configurable from the Tasks preferences page and does not require installation of the UI Experiments feature any longer.

I'll mark this as resolved but we there is a possibility that we will not to reopen and revert in case any unforeseen layout problems with the trim contribution occur.

Comment 11 Jörg Thönnes 2011-02-09 04:10:12 EST

Great news, Steffen!

Thanks for this effort. Now we can omit installing the experimental stuff starting with 3.5.

Comment 12 Steffen Pingel 2011-02-09 05:32:59 EST

Yes, we have always intentionally required expert Mylyn skills to install the Incubator feature and I am leaning towards making the update site even more difficult to find :).

We now have a new weekly build available with the latest changes: http://download.eclipse.org/mylyn/snapshots/weekly . Please let me know if you run into any oddities. 

If you have an older UI Experiments feature installed you may end up with two trims. That can be fixed by either uninstalling the UI Experiments or updating to the latest Incubator build: http://download.eclipse.org/mylyn/incubator/3.5

Comment 13 Jörg Thönnes 2011-02-09 07:23:24 EST

:-) Alas I am using Tasktop ;-) and so I am restricted to the 3.4 builds...

Will ask a colleague to test it if time allows.

Comment 14 Eike Stepper 2011-02-12 02:13:11 EST

(In reply to comment #12)
> We now have a new weekly build available with the latest changes:
> http://download.eclipse.org/mylyn/snapshots/weekly . Please let me know if you
> run into any oddities. 

First I couldn't find it. That was because I was still using the update site your downloads page is pointing to: http://download.eclipse.org/tools/mylyn/update/weekly

Shouldn't you do both remove the old repos and update http://www.eclipse.org/mylyn/downloads ?

With an update fro the new weekly repo I now have the trim widget. Awesome!

Comment 15 Steffen Pingel 2011-02-12 17:04:09 EST

Yes, we are still in the process of migrating files. We'll remove the old update site locations over the course of next couple month.