Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 303203 - [planner] P2 does not pick up higher version of already installed plug-in from dropins
Summary: [planner] P2 does not pick up higher version of already installed plug-in fro...
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5.2   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.5.2+   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 302582
Blocks: 303202
  Show dependency tree
 
Reported: 2010-02-18 11:01 EST by DJ Houghton CLA
Modified: 2010-07-05 10:32 EDT (History)
5 users (show)

See Also:

Attachments
patch against 3.5.x (1.03 KB, patch)
2010-02-18 11:21 EST, DJ Houghton CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2010-02-18 11:01:57 EST 
Cloned to track release into 3.5.x maintenance branch.

+++ This bug was initially created as a clone of Bug #302582 +++

Build Identifier: M20090211-1700, M20090917-0800

If a newer version of already installed plugin (plugin was installed via dropins folder) is added to dropins, P2 does not pick up the highest version. 

Tested with 3_4_maintenance branch classes as well as 3_5_maintenance, in both cases test fails.



Reproducible: Always
Comment 1 DJ Houghton CLA 2010-02-18 11:21:01 EST 
Created attachment 159450 [details]
patch against 3.5.x

Here is a patch for 3.5.x.

Note that we may also have to increment the bundle version in the manifest.

I haven't released this yet because 3.5.2 hasn't been officially declared and didn't want to confused things in the repo if we have to go back and make changes before the train finishes.
Comment 2 DJ Houghton CLA 2010-06-29 11:10:45 EDT 
Natalia, is this patch still needed in the R35x stream or has the problem been fixed with other changes?
Comment 3 Natalia Bartol CLA 2010-07-02 09:56:46 EDT 
(In reply to comment #2)
> Natalia, is this patch still needed in the R35x stream or has the problem been
> fixed with other changes?

This patch is needed in R35x stream. 

In 3.6 stream there is Set<IRequirement> gatheredRequirements but in 3.5 there is still ArrayList gatheredRequirements. This patch is required to avoid duplicated entries.
Comment 4 DJ Houghton CLA 2010-07-05 10:32:50 EDT 
Patch released to branch.
Closing.